Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751884AbeAIJPX (ORCPT + 1 other); Tue, 9 Jan 2018 04:15:23 -0500 Received: from mail-ot0-f194.google.com ([74.125.82.194]:38725 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbeAIJPT (ORCPT ); Tue, 9 Jan 2018 04:15:19 -0500 X-Google-Smtp-Source: ACJfBotzHxZoR3BoF/AQ0jF8f1/qN6WBtyjNBhmQjFDUv8bPfg3keJ0/FDLCH0de5H7u//Nx15BaXupIK03eUfwvXOE= MIME-Version: 1.0 In-Reply-To: <20180109030233.16013-1-yangbo.lu@nxp.com> References: <20180109030233.16013-1-yangbo.lu@nxp.com> From: Fabio Estevam Date: Tue, 9 Jan 2018 07:15:18 -0200 Message-ID: Subject: Re: [v2] net: gianfar_ptp: move set_fipers() to spinlock protecting area To: Yangbo Lu Cc: Claudiu Manoil , Richard Cochran , netdev@vger.kernel.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 9, 2018 at 1:02 AM, Yangbo Lu wrote: > set_fipers() calling should be protected by spinlock in > case that any interrupt breaks related registers setting > and the function we expect. This patch is to move set_fipers() > to spinlock protecting area in ptp_gianfar_adjtime(). > > Signed-off-by: Yangbo Lu > --- > Changes for v2: > - explained why spinlock was needed in commit message. Thanks for improving the commit log: Reviewed-by: Fabio Estevam