Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752180AbeAIJWr (ORCPT + 1 other); Tue, 9 Jan 2018 04:22:47 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:43667 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbeAIJWo (ORCPT ); Tue, 9 Jan 2018 04:22:44 -0500 X-Google-Smtp-Source: ACJfBospxMudyPo4bBvy+EbKKZFhjW9QDFG3C7UkEZAEv9HWTTXBCB7IQdzgYvwaWlOPR4oSEaenhg== Date: Tue, 9 Jan 2018 17:22:32 +0800 From: Dong Aisheng To: Stefan Agner Cc: shawnguo@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Anson Huang , linux-imx@nxp.com Subject: Re: [PATCH 1/7] ARM: imx: add timer stop flag to ARM power off state Message-ID: <20180109092232.GA26312@b29396-OptiPlex-7040> References: <20180102164223.15230-1-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180102164223.15230-1-stefan@agner.ch> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 02, 2018 at 05:42:17PM +0100, Stefan Agner wrote: > When the CPU is in ARM power off state the ARM architected > timers are stopped. The flag is already present in the higher > power WAIT mode. > > This allows to use the ARM generic timer on i.MX 6UL/6ULL SoC. > Without the flag the kernel freezes when the timer enters the > first time ARM power off mode. > > Cc: Anson Huang > Signed-off-by: Stefan Agner It seems ok at my side. Did you meet the real issue? If yes, how to reproduce? Both mx6sx and mx6ul are using GPT which do not need that flag, suppose we should remove it, right? Anson can help confirm it. Regards Dong Aisheng > --- > arch/arm/mach-imx/cpuidle-imx6sx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-imx/cpuidle-imx6sx.c b/arch/arm/mach-imx/cpuidle-imx6sx.c > index c5a5c3a70ab1..d0f14b761ff7 100644 > --- a/arch/arm/mach-imx/cpuidle-imx6sx.c > +++ b/arch/arm/mach-imx/cpuidle-imx6sx.c > @@ -89,6 +89,7 @@ static struct cpuidle_driver imx6sx_cpuidle_driver = { > */ > .exit_latency = 300, > .target_residency = 500, > + .flags = CPUIDLE_FLAG_TIMER_STOP, > .enter = imx6sx_enter_wait, > .name = "LOW-POWER-IDLE", > .desc = "ARM power off", > -- > 2.15.1 >