Date: Tue, 9 Jan 2018 12:51:42 +0100
From: Borislav Petkov <bp@alien8.de>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Andy Lutomirski <luto@kernel.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Milosz Wasilewski <milosz.wasilewski@linaro.org>
Subject: Re: [RFC] selftests/x86: Add test_vsyscall
Message-ID: <20180109115136.sberq4wk2w63b73j@pd.tnic>
References: <17c5ebeb2e00879b0af1a9c32bf37ecdd9b9b31b.1515130397.git.luto@kernel.org>
 <CA+G9fYvZSew8Sg=Xh0u_KDLapjPYnz+PnFOJe5UZ0opa9=VH=Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CA+G9fYvZSew8Sg=Xh0u_KDLapjPYnz+PnFOJe5UZ0opa9=VH=Q@mail.gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org

On Tue, Jan 09, 2018 at 05:15:15PM +0530, Naresh Kamboju wrote:
> We do not want to change the kernel command lines dynamically on
> the test bench. It will be hard to test this case in automated setup.
> Because with a given setup we run all selftests in a single go.

Those cmdline parameters are already upstream, without that test patch.

If you wanna test all, you'd have to change the cmdline or rebuilt the
kernel three times with each of those set, alternatingly:

CONFIG_LEGACY_VSYSCALL_NATIVE
CONFIG_LEGACY_VSYSCALL_EMULATE
CONFIG_LEGACY_VSYSCALL_NONE

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.