Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754860AbeAILwQ (ORCPT + 1 other); Tue, 9 Jan 2018 06:52:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:55522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753209AbeAILwO (ORCPT ); Tue, 9 Jan 2018 06:52:14 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDB5A2173C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=krzk@kernel.org X-Google-Smtp-Source: ACJfBotBj9HhJJjpW0Rm3J85azLOh1au0zZCLZSZZVxURVVg0CKBPq+XJ72q9fPG8fytX8fe4fVdlJYq86kmlbmKVck= MIME-Version: 1.0 In-Reply-To: <1515484746-10656-3-git-send-email-cw00.choi@samsung.com> References: <1515484746-10656-1-git-send-email-cw00.choi@samsung.com> <1515484746-10656-3-git-send-email-cw00.choi@samsung.com> From: Krzysztof Kozlowski Date: Tue, 9 Jan 2018 12:52:11 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/9] soc: samsung: pmu: Add powerup_conf callback To: Chanwoo Choi Cc: Marek Szyprowski , Sylwester Nawrocki , kgene@kernel.org, Tomasz Figa , chanwoo@kernel.org, Jaehoon Chung , Inki Dae , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 9, 2018 at 8:58 AM, Chanwoo Choi wrote: > This patch adds the powerup_conf callback which is used to re-initialize Do not describe every patch as this patch. It does not bring any information because I am already looking at this patch. http://elixir.free-electrons.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151 > the PMU registers during the resume state. > > Signed-off-by: Chanwoo Choi > --- > drivers/soc/samsung/exynos-pmu.c | 8 ++++++++ > drivers/soc/samsung/exynos-pmu.h | 1 + > include/linux/soc/samsung/exynos-pmu.h | 1 + > 3 files changed, 10 insertions(+) > > diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c > index f56adbd9fb8b..cfc9de518344 100644 > --- a/drivers/soc/samsung/exynos-pmu.c > +++ b/drivers/soc/samsung/exynos-pmu.c > @@ -58,6 +58,14 @@ void exynos_sys_powerdown_conf(enum sys_powerdown mode) > pmu_data->powerdown_conf_extra(mode); > } > > +void exynos_sys_powerup_conf(enum sys_powerdown mode) > +{ > + const struct exynos_pmu_data *pmu_data = pmu_context->pmu_data; > + Follow the existing pattern of exynos_sys_powerdown_conf() to check if pmu_context was initialized. At this commit, for Exynos5433 it is not being set. Best regards, Krzysztof > + if (pmu_data->powerup_conf) > + pmu_data->powerup_conf(mode); > +} > + > /* > * Split the data between ARM architectures because it is relatively big > * and useless on other arch. > diff --git a/drivers/soc/samsung/exynos-pmu.h b/drivers/soc/samsung/exynos-pmu.h > index 977e4daf5a0f..efbaf8929252 100644 > --- a/drivers/soc/samsung/exynos-pmu.h > +++ b/drivers/soc/samsung/exynos-pmu.h > @@ -24,6 +24,7 @@ struct exynos_pmu_data { > void (*pmu_init)(void); > void (*powerdown_conf)(enum sys_powerdown); > void (*powerdown_conf_extra)(enum sys_powerdown); > + void (*powerup_conf)(enum sys_powerdown); > }; > > extern void __iomem *pmu_base_addr; > diff --git a/include/linux/soc/samsung/exynos-pmu.h b/include/linux/soc/samsung/exynos-pmu.h > index e57eb4b6cc5a..3aacf7b18401 100644 > --- a/include/linux/soc/samsung/exynos-pmu.h > +++ b/include/linux/soc/samsung/exynos-pmu.h > @@ -22,6 +22,7 @@ enum sys_powerdown { > }; > > extern void exynos_sys_powerdown_conf(enum sys_powerdown mode); > +extern void exynos_sys_powerup_conf(enum sys_powerdown mode); > #ifdef CONFIG_EXYNOS_PMU > extern struct regmap *exynos_get_pmu_regmap(void); > #else > -- > 1.9.1 >