Date: Tue, 9 Jan 2018 12:57:48 +0100
From: Johan Hovold <johan@kernel.org>
To: Mikhail Zaytsev <flashed@mail.ru>
Cc: Johan Hovold <johan@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] USB: serial: ark3116: Move TIOCGSERIAL ioctl case
 to function.
Message-ID: <20180109115748.GT11344@localhost>
References: <20180106200809.41cdd723@debian>
 <20180106201522.7a542d44@debian>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180106201522.7a542d44@debian>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org

On Sat, Jan 06, 2018 at 08:15:22PM +0300, Mikhail Zaytsev wrote:
> The patch moves TIOCGSERIAL ioctl case to get_serial_info function.
> 
> Signed-off-by: Mikhail Zaytsev <flashed@mail.ru>

>  static int ark3116_ioctl(struct tty_struct *tty,
>  			 unsigned int cmd, unsigned long arg)
>  {
>  	struct usb_serial_port *port = tty->driver_data;
> -	struct serial_struct serstruct;
> -	void __user *user_arg = (void __user *)arg;

I prefer keeping this pointer here to avoid adding casts to every helper
function call, so I added it back before applying.

>  
>  	switch (cmd) {
>  	case TIOCGSERIAL:

> +		return ark3116_get_serial_info(port,
> +					(struct serial_struct __user *)arg);

Thanks,
Johan