Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751689AbeAIMSL (ORCPT + 1 other); Tue, 9 Jan 2018 07:18:11 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:44466 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175AbeAIMSJ (ORCPT ); Tue, 9 Jan 2018 07:18:09 -0500 MIME-Version: 1.0 Message-ID: <73076023-1778-4c4b-b06c-9d7c9a0ea118@default> Date: Tue, 9 Jan 2018 04:17:52 -0800 (PST) From: Liran Alon To: Cc: , , , , , , , , Subject: Re: [PATCH 1/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT accessors X-Mailer: Zimbra on Oracle Beehive Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8768 signatures=668652 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801090173 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: ----- pbonzini@redhat.com wrote: > As an interim measure until SPEC_CTRL is supported by upstream > Linux in cpufeatures, add a function that lets vmx.c and svm.c > know whether to save/restore MSR_IA32_SPEC_CTRL. > > Reviewed-by: Konrad Rzeszutek Wilk > Signed-off-by: Paolo Bonzini > --- > arch/x86/kvm/cpuid.c | 3 --- > arch/x86/kvm/cpuid.h | 22 ++++++++++++++++++++++ > 2 files changed, 22 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c > index 8e9a07c557f1..767af697c20c 100644 > --- a/arch/x86/kvm/cpuid.c > +++ b/arch/x86/kvm/cpuid.c > @@ -67,9 +67,6 @@ u64 kvm_supported_xcr0(void) > > #define F(x) bit(X86_FEATURE_##x) > > -/* These are scattered features in cpufeatures.h. */ > -#define KVM_CPUID_BIT_AVX512_4VNNIW 2 > -#define KVM_CPUID_BIT_AVX512_4FMAPS 3 > #define KF(x) bit(KVM_CPUID_BIT_##x) > > int kvm_update_cpuid(struct kvm_vcpu *vcpu) > diff --git a/arch/x86/kvm/cpuid.h b/arch/x86/kvm/cpuid.h > index c2cea6651279..8d04ccf177ce 100644 > --- a/arch/x86/kvm/cpuid.h > +++ b/arch/x86/kvm/cpuid.h > @@ -155,6 +155,28 @@ static inline int guest_cpuid_stepping(struct > kvm_vcpu *vcpu) > return x86_stepping(best->eax); > } > > +/* These are scattered features in cpufeatures.h. */ > +#define KVM_CPUID_BIT_AVX512_4VNNIW 2 > +#define KVM_CPUID_BIT_AVX512_4FMAPS 3 > +#define KVM_CPUID_BIT_SPEC_CTRL 26 > +#define KVM_CPUID_BIT_STIBP 27 > + > +/* CPUID[eax=0x80000008].ebx */ > +#define KVM_CPUID_BIT_IBPB_SUPPORT 12 > + > +static inline bool cpu_has_spec_ctrl(void) > +{ > + u32 eax, ebx, ecx, edx; > + cpuid_count(7, 0, &eax, &ebx, &ecx, &edx); > + > + return edx & bit(KVM_CPUID_BIT_SPEC_CTRL); > +} > + > +static inline bool cpu_has_ibpb_support(void) > +{ > + return cpuid_ebx(0x80000008) & bit(KVM_CPUID_BIT_IBPB_SUPPORT); > +} > + > static inline bool supports_cpuid_fault(struct kvm_vcpu *vcpu) > { > return vcpu->arch.msr_platform_info & > MSR_PLATFORM_INFO_CPUID_FAULT; > -- > 1.8.3.1 Reviewed-by: Liran Alon