Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754258AbeAIMUC (ORCPT + 1 other); Tue, 9 Jan 2018 07:20:02 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:37185 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752070AbeAIMUB (ORCPT ); Tue, 9 Jan 2018 07:20:01 -0500 X-Greylist: delayed 574 seconds by postgrey-1.27 at vger.kernel.org; Tue, 09 Jan 2018 07:20:00 EST X-IronPort-AV: E=Sophos;i="5.46,335,1511827200"; d="scan'208";a="465135832" From: Ross Lagerwall To: CC: Ross Lagerwall , Boris Ostrovsky , Juergen Gross , Subject: [PATCH 1/2] xen/gntdev: Fix off-by-one error when unmapping with holes Date: Tue, 9 Jan 2018 12:10:21 +0000 Message-ID: <20180109121022.11467-1-ross.lagerwall@citrix.com> X-Mailer: git-send-email 2.9.5 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: If the requested range has a hole, the calculation of the number of pages to unmap is off by one. Fix it. Signed-off-by: Ross Lagerwall --- drivers/xen/gntdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 57efbd3..d3391a1 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -380,10 +380,8 @@ static int unmap_grant_pages(struct grant_map *map, int offset, int pages) } range = 0; while (range < pages) { - if (map->unmap_ops[offset+range].handle == -1) { - range--; + if (map->unmap_ops[offset+range].handle == -1) break; - } range++; } err = __unmap_grant_pages(map, offset, range); -- 2.9.5