Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753838AbeAINRn (ORCPT + 1 other); Tue, 9 Jan 2018 08:17:43 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:38466 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751719AbeAINRl (ORCPT ); Tue, 9 Jan 2018 08:17:41 -0500 MIME-Version: 1.0 Message-ID: Date: Tue, 9 Jan 2018 05:17:21 -0800 (PST) From: Liran Alon To: Cc: , , , , , , , , Subject: Re: [PATCH 5/8] KVM: SVM: fix comment X-Mailer: Zimbra on Oracle Beehive Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8768 signatures=668652 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=634 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801090188 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: ----- pbonzini@redhat.com wrote: > If always==true, then read/write bits are cleared from > the MSR permission bitmap, thus passing-through the MSR. > Fix the comment to match reality. > > Signed-off-by: Paolo Bonzini > --- > arch/x86/kvm/svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index 55dde3896898..31ace8d7774a 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -236,7 +236,7 @@ struct amd_svm_iommu_ir { > > static const struct svm_direct_access_msrs { > u32 index; /* Index of the MSR */ > - bool always; /* True if intercept is always on */ > + bool always; /* True if intercept is always off */ > } direct_access_msrs[] = { > { .index = MSR_STAR, .always = true }, > { .index = MSR_IA32_SYSENTER_CS, .always = true }, > -- > 1.8.3.1 Reviewed-by: Liran Alon