Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758383AbeAIN4t (ORCPT + 1 other); Tue, 9 Jan 2018 08:56:49 -0500 Received: from mail-dm3nam03on0086.outbound.protection.outlook.com ([104.47.41.86]:23363 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758216AbeAINzl (ORCPT ); Tue, 9 Jan 2018 08:55:41 -0500 Authentication-Results: spf=pass (sender IP is 129.130.18.151) smtp.mailfrom=ksu.edu; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=ksu.edu; X-Google-Smtp-Source: ACJfBovmNVCwaGTEY61RCRbf9RhUvNIO9CwaX8kAa0d41WefwCsfmj5UDPlt1T+tNii5Ko40GKT/1uJEQGKB6HY0QsE= MIME-Version: 1.0 In-Reply-To: <20180109133412.uyai4s6vfnh37hn2@flea> References: <20171219210523.10428-1-kevans91@ksu.edu> <20171221145512.llxvzkcrjpquhczi@flea.lan> <20171221152630.2vf57x5o2yi5sv3n@flea.lan> <20171221190903.56ebae536acf51401c63802c@bidouilliste.com> <20171222083508.dfcp6egfvxykmogg@flea.lan> <20171222110727.520df7394234f6a5dc0b9ec0@bidouilliste.com> <20180104140119.5pyfihp4zs2poz35@flea.lan> <20180109133412.uyai4s6vfnh37hn2@flea> From: Kyle Evans Date: Tue, 9 Jan 2018 07:55:13 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t To: Maxime Ripard CC: Chen-Yu Tsai , Emmanuel Vadot , Mark Rutland , devicetree , linux-kernel , Russell King , linux-sunxi , Rob Herring , Srinivas Kandagatla , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:129.130.18.151;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(346002)(39380400002)(39860400002)(376002)(396003)(2980300002)(438002)(24454002)(199004)(189003)(61266001)(9896002)(498394004)(9686003)(2906002)(88552002)(55446002)(86362001)(90966002)(450100002)(229853002)(4326008)(59536001)(5820100001)(47776003)(53546011)(95326003)(42186006)(59450400001)(75432002)(106002)(16586007)(8936002)(316002)(76176011)(61726006)(2950100002)(98316002)(786003)(305945005)(356003)(50466002)(33896004)(54906003)(93516011)(6862004)(5660300001)(93886005)(478600001)(6246003)(107886003)(8676002)(246002)(106466001)(23676004)(55456009);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR05MB2984;H:ome-vm-smtp2.campus.ksu.edu;FPR:;SPF:Pass;PTR:ip-18-151.net.ksu.edu;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02FT010;1:83ExTNL6DhqVrPrQrZrcxz9S6dTEE7mE0O5lYNjYxgdGvMiVzimPY3DPkKSKHKaWnQd7AsSAio2gfhcDFM4VY7zqmbgKd4RGMz3NGkhmmJ63ozaSqlyi9h3D7qWn5FQ+ X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d420bf2c-15c4-4445-5d10-08d55768aa9b X-Microsoft-Antispam: UriScan:(198831570735186);BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(8989060)(201703031133081)(201702281549075)(8990040)(5600026)(4604075)(4608076)(2017052603307)(7153060);SRVR:CY4PR05MB2984; X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB2984;3:PoRBCU4iM0CVD5VSruHs6kAuJp6Me6MqZ2vPxSLKlId14e+igb7wANhOIDwgpowQ3AKhijHejFdv6H8IyMNV/TFIjre6JWiW1psUMNpTj34xhAJzUXlhnhdgeLWG3Rf0XZd7IoJ+EeW+cjg5s06e75x2gFHZU/hg0yo7fovHtcEwPfuMdXnRTuLgXurQcuncJrwvWSfGqqLXxI5z2YQxdzYPvfZKPOT5nIF4yyh/cHneU3Lz7IoEceWEMMyZ3PsW97JiAn3eW5iXC2nmazr9CJeyno6hsBvRUEzKBRzFbTfMYMuVP7BXnICe8TkzBNiauuOAzA/bDbFC3uizKmayDdQfHxH7EqXzRP7i2bT4K3GlKu8TNQIrAJS2s8gm1A6brx9SbUO3vjrIJI0ceEv/tg==;25:9n6oDqsDieE/kaD0A+U1jHAAPU0ji3IwCg9MeIVIGxSZIQ0utbN/QvM17yyQ8nIjdwYBL1uxFqwq8Y974+wRovTJy6bUyLKhSzXehqiOQFOUBK7E3cyFZ2SjVIhWR2TSK/iKNNclqTxE85913fy4eQCes+SGV30vBN1jeBxe/cvcW3nvj8GWN8BZuTIKErXLo0PCSqRXXL+hzcRZR/4ybCJM4s/GazrTeR6PiU2cT+RVVSibD5/vXutzT5nmROTnOVMEfC1wejdr/K04Egp0N00Vv8RU4FTaa4My1hdYMgJA2bA/CvSqTzIh4v/aQSFxeWZ/KFPOxSr8dzwHuX2C1w== X-MS-TrafficTypeDiagnostic: CY4PR05MB2984: X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB2984;31:cQHqOuVYYU4xUOrcvL1uNWdDJLFbR2mlNFDqKD0u28Yw8RylgyuSVbhBHLtAIVt8tRVuQM3TgCe1t8vKjMrfwHMO9fmR8Q9HcL3WZ836QjV1R8n4k0zT2h/rhX/ZnfIJJXPC5j1YOAIqJY59bOhL85e/Foy729hOMQXk4LaumVweeUlh/JUrUWe/IY739ZYv7lTmuPsqOU52RhLyy2W8dHe4LM3neOsE+egBwlOKSqo=;20:hEwwA0ZE8SnKJ2w5ylA2UgMU8eJ5g9Kxa3SNv08osvlmaezBPSvORaGGoOrAcC8h4BndWz0Q8ZfgXni2T6HPAOapcgYrCSBRy1xERakXgMisLLBH6izQQgy+K0yW5vjFHGjNyZcCC16OzpI4uviyjB8HjwQa40KiLbc5J7euY2QnCgTnniRV2q58mAT327osIT4j3k0z7NsYR15Oti/JCaFlSU0lNE73VvphxSFopM9emOg0+7zPIMcAkzK583hDihbsips9O1oCiaJxlupPBu4l43mOV1ct0q2TQGFsmfu6bCFkKnZOD6ezHyeFyvR4i8DpLCtWAz46VnIj9WF0+VfmUtsB/adMnJtwpG3NbHk8eAeHfTv8CSTpw6Jb7pqBalp2o14Xk2OqApLFZG0ibfg/jHazmu0okBJPmOhwaYZK7SldmVp1YVOiV7Uspii2tCt2OR+ETIhBkVCvcf/g0MOm6QsQLJ1p3xqQOBFhb7XeBnR/IvlZhKwrYPVfSmCf X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(112903893386949)(198831570735186)(58145275503218); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(3231023)(944501075)(3002001)(93006095)(93004095)(6041268)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:CY4PR05MB2984;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY4PR05MB2984; X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB2984;4:qWbLzHXGGgencddr1FYW4aizroNAJ5Jj+dfsqS0ktqyH/Na9V4Ydv7Dq2JrAxclnMqle9BlYqHcJxcLKCUYqjhQF1ocmTNwd1IdqLPTeoR1rtORKZNmBf1A8nD3hgWNldkRpMHY5AH7NLHn8mfbflBQIiHoba72toaoT4JmcfJOinqsYmNgcg3OPwI5d/rFggw9Q7f5VJNOl9S1OL3TFLA4ipicjNKXMRPAnUmJnC8s02KdYR5IG8mhG3OWQ84S8jbsDuPudTAOPtHU5EaqMp4D8UxsUtXOZd9t8lDYp0Eb205ADicH55yOg/gkIDqA1SKN3Qv7k8uRLP1f+tY2AFiN5o5TQIyQoq8pWKQytLxf+Ub03c+e/c7tYrQ4JW+BU+rbN64AbRxOCHN8X0UC4pKsK1ycj5QfCvSKd4kgAtDU= X-Forefront-PRVS: 0547116B72 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjA1TUIyOTg0OzIzOjgwYVdqd2ZOTFdOakdTRHF6RnpqVkNYV3pI?= =?utf-8?B?WW1QamgwM2ZtaEdGdnhNN2NtVnBsVDhGbFc3elhRT2l1S0V3QmdkT0tlejdG?= =?utf-8?B?TlVqN2xnL0dHdVJRZXZQSjVIV2hmT1FJWWY4UytscVBNT3piZ0NHT0E5MkpB?= =?utf-8?B?cDhsWXNHM3NHVjRFNCt5Tm13ZUV1MCttQW9oVDNJc3RwaWR2elgyQWVuelcr?= =?utf-8?B?TTYzdmM4cXdIeFBLS2N0cnhSbDBTSk1laWQwTVltYTZLWWhiMVRnb1ZNQktR?= =?utf-8?B?STN1clhBbS9TYURpOStzaDFJa09HdzJmckszMUNneUhPUlc0czBnK2gwOFV4?= =?utf-8?B?Rjl4blJ5Y0QwWnc1RDVkWGVSMVFlZnN1SGNxWmt5Ym5icjF6Q2wybGZQQVBK?= =?utf-8?B?MkZmbXUrcFJTMERNbnltdDUrQURaWTl0dUhBRjV0WVZtQ1pNUzZBZ21ybEVS?= =?utf-8?B?WEF4UXFvQU5Od0RlRjNYclIydGJkcjFGTnVFNWRJTE01QzdzUm5CMlJDN0ZR?= =?utf-8?B?V2Zud2YxbmNuWXU5MmdXY1hNTE9aMk9WcDVHR29hcHBZelNYQ211a29BUUty?= =?utf-8?B?b0hUc3hGd1ljK1RPbnB1UVlOOWFRbHErU1k4amluL3ZxZ2dSWXUyemFyZi8x?= =?utf-8?B?UE40SnJNdU1VV2pSKytaQUIwMjUwU2RsMTZyK2laWU1QaVBNVm9NempydERB?= =?utf-8?B?NkhQcmNBV3o3UEFyUndoK0ZVdTY4bi82ZlRGZTRyd2dHMVdsSjdSUVVIVHBi?= =?utf-8?B?cGJNVjNvVEtOaUV0UUFPRTQ1eFIxNDgxVmNySU9ucWxteVlQc2k2Y2lSdXJF?= =?utf-8?B?US9WYStHcUw1elVIWlZSREZoZW5WUjQ1SXoyT29zN3hJMG82QzFVWThiNlRB?= =?utf-8?B?TW0vZFkrR3lwa2p1VXcvWlRzWnp4NWZUQTZyZmRmYlJSUUFqRG5MWm1Gejh5?= =?utf-8?B?bmdPSE1aYTluc1oxemdxRVdTNFNoM2Q5eWFFV0RCenozR1VOeTEwZC9LMC9T?= =?utf-8?B?a3RJNWFTSUEzblNTUG1SZ3BVVUpvWlczV21vTVVJcW5SS2w5WkQ3dHFaN0Mx?= =?utf-8?B?OWZLSWtENkZYSnFrWWxkcVh6MGJRZ2VHS0poZklhOStuOUI4dW1FTnB5UEZL?= =?utf-8?B?UWVhcndneFNIQ1ZYK00weFFCcnp2dER1dHhtVWNiZ3YwbnR0TUNEaHlteDZu?= =?utf-8?B?MGdMVHhXZWJiY2VSZ3VuNlp4bjVFejlNNFVUSW5jKzVDS29ZRWR6WjdqZU9O?= =?utf-8?B?TDNjVUNadm03NXV1WmQ4TmdYTE1QZ1ZLMFhzZkp4ZW1yMUMwWCs5QzZCYml4?= =?utf-8?B?T1RYSWJDZUFLSU9xakZqNGM1cXB2emVyY2tXcnlGYjJkclBXT1BDa3BtdjY5?= =?utf-8?B?Y1dyWmhJbHZhL0Fvb2sxKzFQNVpYZXJqdlpsUElmUjVBT3ZTN0NDM2NTWDlB?= =?utf-8?B?Ti9IUnpVN2pJUUVQRHd2VFlWSGdRM2tnTlRPQUMzckRJdGU1WFg1VzBFTFFP?= =?utf-8?B?N25oYXRtV0RFSjcxaDlwTldBblo4Nmh5dEE5V2VEMWY5TjlZK0NxeS9mQi9D?= =?utf-8?B?ZGt3YVgreXRpRjYzVWovYmh4dWlkRkRGemtvMkF2VmhyVFpjdU9pNVdTbXNr?= =?utf-8?B?bmFIQ01HaUdSUUdVSE9GOHRaeW0wdUJHL1VZcTJFVWZZVlM1bXNmQXkxU0Nr?= =?utf-8?B?MG85RFBIVitQbTZWRExPMldHdi9KTW5ieEZjeUc5ampkcDVNTi8yVFdWYkpp?= =?utf-8?B?eks2eFROVGVGUzdHZ0RjQT09?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB2984;6:7IMn5U2UUNUoUkf9t7oSmZYbABkLbcZMOthHzOJdmufj2Jbz1z/TzIwRRUJcJaXcLTRCN7DyyweNRIPW5L8AgpYX9KEO5xnT3OnFrb/HIU9GhB5a/tQaC8QO7xKkQceMc606/YKOYJN4QEhZ8iRnzRM8oCl+AmdZapCVzQChKSBwcYpH2BE77W1QngUMeAq7pCfqDvw9oux1jyq/4/kk3e1bTaWxUBPVfA/aUVJhM2mbDo+dT3Ssz4cf9zLJA2tZSf5F2v/kJw8+mHFDA6WF1VpnZHoY/lLtcd/3EbyWZFUtwHNN+25ZDrcu5USa3mKLOk3yR0+M5SIGLh3Y+KcaqWRk34mDxN/Vy4JzIYqEs58=;5:9i57Y4dU6z2xpCW127kKMUW8o849J2f0N6ZJ3Rs24FGO8fzhWDuonoR3rUWdZGSAFzSl2DJ9SfehcKz/EdTTxpCRjivqr/5bnAzquwlav/lNYwk0KB9EQSb0SWKgBi6BMXEk5AjhD6nD5jMHCxX+u9NR9IagQsWVOhSfxV3PY4k=;24:3dCnbjoTnaXG33A5OBo7+DjL6d4h7usTKMTAKNs/dKpATPNOc631pEyMoDnfPP4SOh2FxMSpemFjseJmF6mRRSfmYk1seutsBvUfnXwKtqU=;7:o9U8WEIB4yiXIXXI2393XDQhHvI2CjDIeXxKOCQwoA0Kzk/2PmRpu+eJmcJ3ft9JVJwNR1hfGVnSI+ld/Gp5+WXLQTNehRacMr69++7qChrkfwNb3V+ujSWv/diXsE3ksQOK8GJBHZQL9U8J/BFCxTQFXaECRfjdul4tQev0nXBmIfdmf/NAixUeXAfUpVd3+LAeleroC1TJBdbRmp/uEEypkH0stprMZb6It/vbsashvHYnVbYSw/UClym9HOiy SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB2984;20:hpMrsMdyaL09P6mputwDWSOb7voMeKoMH9XGaJnNMKFVn8rm0XaoSKl4I0Cud/vnyjtQYvhV1Kjdpdp44uQL46qbLvXyXzrORQSaNcR4NMb6i2LC8lEewspwmtd4dHTRSGGEB/fGCEOqbhhwFzBnQfhxSOe2jK5rkWmd5XxxA64= X-OriginatorOrg: ksu.edu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2018 13:55:37.7366 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d420bf2c-15c4-4445-5d10-08d55768aa9b X-MS-Exchange-CrossTenant-Id: d9a2fa71-d67d-4cb6-b541-06ccaa8013fb X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d9a2fa71-d67d-4cb6-b541-06ccaa8013fb;Ip=[129.130.18.151];Helo=[ome-vm-smtp2.campus.ksu.edu] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR05MB2984 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 9, 2018 at 7:34 AM, Maxime Ripard wrote: > On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: >> On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard >> wrote: >> > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: >> >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot wrote: >> >> > On Fri, 22 Dec 2017 09:35:08 +0100 >> >> > Maxime Ripard wrote: >> >> > >> >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> >> >> > >> >> >> > Hi Maxime, >> >> >> > >> >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> >> >> > Maxime Ripard wrote: >> >> >> > >> >> >> > > Hi, >> >> >> > > >> >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> >> >> > > > wrote: >> >> >> > > > > Hi Kyle, >> >> >> > > > > >> >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> >> > > > >> thermal calibration data, add node to describe it. >> >> >> > > > >> >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> >> > > > >> supported in an external driver for FreeBSD. >> >> >> > > > >> >> >> >> > > > >> Signed-off-by: Kyle Evans >> >> >> > > > > >> >> >> > > > > The patch looks fine in itself, but we've had a number of issues with >> >> >> > > > > the register layout (and access patterns) in the past, so I'd rather >> >> >> > > > > have something that works in Linux too if possible. >> >> >> > > > >> >> >> > > > I have a patch that I think should make it work fine on Linux [1], but >> >> >> > > > I'm afraid I have little to no capability to test it myself and so I >> >> >> > > > did not add it as well. >> >> >> > > > >> >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> >> >> > > > as is the case with the H3, and that the readout quirk is not needed. >> >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> >> >> > > > this space. >> >> >> > > >> >> >> > > Then maybe we should leave it aside until someone takes some time on >> >> >> > > the A83t. >> >> >> > >> >> >> > Take some time on the Linux driver and do not apply this patch for >> >> >> > now you mean ? >> >> >> >> >> >> Yep. >> >> >> >> >> >> Maxime >> >> > >> >> > Since linux doesn't have the compatible in it's driver what would >> >> > be the harm to add the node in the DTS ? If a quirks is needed because >> >> > some region is weird this would go in the driver right ? I don't see a >> >> > technical problem for adding this node right now. >> >> > If Kyle confirm the lenght of the region and that no quirk is needed >> >> > will it be enough ? >> >> >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device >> >> node currently says nothing about how much efuse space there is. The >> >> memory region covers that and the control section, and the size matches >> >> what the memory map says. >> >> >> >> The size and offset of the efuse space would be dealt with in the driver. >> > >> > Let's merge it then. >> > >> > Acked-by: Maxime Ripard >> >> What does the timeline for these things normally look like? I'm new to >> these parts. =) > > We're one week away from the merge window, so it's a bit late for it > to be merged in 4.16, but it'll be in 4.17. Ok, cool, that makes sense. Thanks!