Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754355AbeAIOHJ (ORCPT + 1 other); Tue, 9 Jan 2018 09:07:09 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:57941 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752198AbeAIOHH (ORCPT ); Tue, 9 Jan 2018 09:07:07 -0500 Date: Tue, 9 Jan 2018 15:07:05 +0100 From: Alexandre Belloni To: Linus Walleij Cc: linux-gpio@vger.kernel.org, Ralf Baechle , Linux MIPS , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] pinctrl: Add Microsemi Ocelot SoC driver Message-ID: <20180109140705.GC2719@piout.net> References: <20180106000926.13770-1-alexandre.belloni@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 09/01/2018 at 14:56:36 +0100, Linus Walleij wrote: > On Sat, Jan 6, 2018 at 1:09 AM, Alexandre Belloni > wrote: > > > The Microsemi Ocelot SoC has a few pins that can be used as GPIOs or take > > multiple other functions. Add a driver for the pinmuxing and the GPIOs. > > > > There is currently no support for interrupts. > > > > Signed-off-by: Alexandre Belloni > > --- > > - use pinctrl_gpio_direction_input/output from > > ocelot_gpio_direction_input/output > > - add a comment for ALT0/ALT1 > > - fill .max_register of ocelot_pinctrl_regmap_config > > Patch applied. And it looks very good too. > > This was all I had to do, right? No dependent patches? > Nothing more for you, thanks! I'll get back to this driver if there is interest in having IRQ support but I don't think this will happen soon. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com