Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758767AbeAIPRt (ORCPT + 1 other); Tue, 9 Jan 2018 10:17:49 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:60006 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754379AbeAIPRr (ORCPT ); Tue, 9 Jan 2018 10:17:47 -0500 Date: Tue, 9 Jan 2018 16:17:35 +0100 From: Antoine Tenart To: Russell King - ARM Linux Cc: Antoine Tenart , davem@davemloft.net, kishon@ti.com, andrew@lunn.ch, gregory.clement@free-electrons.com, mw@semihalf.com, stefanc@marvell.com, ymarkman@marvell.com, thomas.petazzoni@free-electrons.com, miquel.raynal@free-electrons.com, nadavh@marvell.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 4/4] net: mvpp2: 2500baseX support Message-ID: <20180109151735.GB23676@kwain> References: <20180109085945.11916-1-antoine.tenart@free-electrons.com> <20180109085945.11916-5-antoine.tenart@free-electrons.com> <20180109144447.GI17719@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180109144447.GI17719@n2100.armlinux.org.uk> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Russell, On Tue, Jan 09, 2018 at 02:44:48PM +0000, Russell King - ARM Linux wrote: > On Tue, Jan 09, 2018 at 09:59:45AM +0100, Antoine Tenart wrote: > > This patch adds the 2500Base-X PHY mode support in the Marvell PPv2 > > driver. 2500Base-X is quite close to 1000Base-X and SGMII modes and uses > > nearly the same code path. > > Sorry, also... Comments always welcomed :) > > @@ -4668,6 +4692,10 @@ static void mvpp2_port_mii_gmac_configure_mode(struct mvpp2_port *port) > > */ > > val |= MVPP2_GMAC_CONFIG_GMII_SPEED | > > MVPP2_GMAC_CONFIG_FULL_DUPLEX; > > + else if (port->phy_interface == PHY_INTERFACE_MODE_2500BASEX) > > + val |= MVPP2_GMAC_CONFIG_GMII_SPEED | > > + MVPP2_GMAC_CONFIG_MII_SPEED | > > + MVPP2_GMAC_CONFIG_FULL_DUPLEX; > > I think you'll find you don't need to set MII_SPEED here, since > MII_SPEED selects between 10 and 100, GMII_SPEED always takes > precidence selecting 1000, and 2500 is done by the comphy > increasing the clocks by 2.5x. I just had a look at the datasheet, and as you say it seems GMII_SPEED takes over MII_SPEED. I'll see if there is a corner case here or if selecting MII_SPEED doesn't make sense, and update accordingly. Thanks! Antoine -- Antoine T?nart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com