Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933477AbeAIPqH (ORCPT + 1 other); Tue, 9 Jan 2018 10:46:07 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:39174 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751263AbeAIPqE (ORCPT ); Tue, 9 Jan 2018 10:46:04 -0500 Subject: Re: [PATCH 10/13] ocxl: Add Makefile and Kconfig To: Andrew Donnellan , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: arnd@arndb.de, gregkh@linuxfoundation.org, mpe@ellerman.id.au, alastair@au1.ibm.com References: <9cf29972-8995-949f-1435-70f0e11071cf@au1.ibm.com> From: Frederic Barrat Date: Tue, 9 Jan 2018 16:45:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <9cf29972-8995-949f-1435-70f0e11071cf@au1.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18010915-0020-0000-0000-000003E898E4 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18010915-0021-0000-0000-0000427AB9B8 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-09_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801090223 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Le 03/01/2018 à 06:48, Andrew Donnellan a écrit : > On 19/12/17 02:21, Frederic Barrat wrote: >> OCXL_BASE triggers the platform support needed by the driver. >> >> Signed-off-by: Frederic Barrat >> --- >>   drivers/misc/Kconfig       |  1 + >>   drivers/misc/Makefile      |  1 + >>   drivers/misc/ocxl/Kconfig  | 25 +++++++++++++++++++++++++ >>   drivers/misc/ocxl/Makefile | 10 ++++++++++ >>   4 files changed, 37 insertions(+) >>   create mode 100644 drivers/misc/ocxl/Kconfig >>   create mode 100644 drivers/misc/ocxl/Makefile >> >> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig >> index f1a5c2357b14..0534f338c84a 100644 >> --- a/drivers/misc/Kconfig >> +++ b/drivers/misc/Kconfig >> @@ -508,4 +508,5 @@ source "drivers/misc/mic/Kconfig" >>   source "drivers/misc/genwqe/Kconfig" >>   source "drivers/misc/echo/Kconfig" >>   source "drivers/misc/cxl/Kconfig" >> +source "drivers/misc/ocxl/Kconfig" >>   endmenu >> diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile >> index 5ca5f64df478..73326d54e246 100644 >> --- a/drivers/misc/Makefile >> +++ b/drivers/misc/Makefile >> @@ -55,6 +55,7 @@ obj-$(CONFIG_CXL_BASE)        += cxl/ >>   obj-$(CONFIG_ASPEED_LPC_CTRL)    += aspeed-lpc-ctrl.o >>   obj-$(CONFIG_ASPEED_LPC_SNOOP)    += aspeed-lpc-snoop.o >>   obj-$(CONFIG_PCI_ENDPOINT_TEST)    += pci_endpoint_test.o >> +obj-$(CONFIG_OCXL)        += ocxl/ >> >>   lkdtm-$(CONFIG_LKDTM)        += lkdtm_core.o >>   lkdtm-$(CONFIG_LKDTM)        += lkdtm_bugs.o >> diff --git a/drivers/misc/ocxl/Kconfig b/drivers/misc/ocxl/Kconfig >> new file mode 100644 >> index 000000000000..4496b61f48db >> --- /dev/null >> +++ b/drivers/misc/ocxl/Kconfig >> @@ -0,0 +1,25 @@ >> +# >> +# Open Coherent Accelerator (OCXL) compatible devices >> +# >> + >> +config OCXL_BASE >> +    bool >> +    default n >> +    select PPC_COPRO_BASE >> + >> +config OCXL >> +    tristate "Support for Open Coherent Accelerators (OCXL)" >> +    depends on PPC_POWERNV && PCI && EEH >> +    select OCXL_BASE >> +    default m >> +    help >> + >> +      Select this option to enable driver support for Open >> +      Coherent Accelerators (OCXL).  OCXL is otherwise known as >> +      Open Coherent Accelerator Processor Interface (OCAPI). >> +      OCAPI allows accelerators in FPGAs to be coherently attached >> +      to a CPU through a Open CAPI link.  This driver enables >> +      userspace programs to access these accelerators through >> +      devices found in /dev/ocxl/ > > I'd prefer more consistency in how we refer to OpenCAPI. "ocxl" is a > driver name that we have purely for historical reasons, it's not really > the name of anything else. I know throughout the various specs and code, > we use "OCAPI" a lot, but that's not really an abbreviation that should > be "user-facing". > > Something like: > > config OCXL >      tristate "OpenCAPI coherent accelerator support" >      help > >        Select this option to enable the ocxl driver for Open Coherent >        Accelerator Processor Interface (OpenCAPI) devices. > >        OpenCAPI allows FPGA and ASIC accelerators to be coherently >        attached to a CPU over an OpenCAPI link. > >        The ocxl driver enables userspace programs to access these >        accelerators through devices in /dev/ocxl/. > >        For more information, see http://opencapi.org. > >        If unsure, say N. > Agreed, and stolen. Fred >> + >> +      If unsure, say N. >> diff --git a/drivers/misc/ocxl/Makefile b/drivers/misc/ocxl/Makefile >> new file mode 100644 >> index 000000000000..f75853411cfd >> --- /dev/null >> +++ b/drivers/misc/ocxl/Makefile >> @@ -0,0 +1,10 @@ >> +ccflags-$(CONFIG_PPC_WERROR)    += -Werror >> + >> +ocxl-y                += main.o pci.o config.o file.o pasid.o >> +ocxl-y                += link.o context.o afu_irq.o sysfs.o trace.o >> +obj-$(CONFIG_OCXL)        += ocxl.o >> + >> +# For tracepoints to include our trace.h from tracepoint infrastructure: >> +CFLAGS_trace.o := -I$(src) >> + >> +# ccflags-y += -DDEBUG >> >