Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933955AbeAIQDI (ORCPT + 1 other); Tue, 9 Jan 2018 11:03:08 -0500 Received: from mail-qk0-f172.google.com ([209.85.220.172]:34623 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933094AbeAIQDE (ORCPT ); Tue, 9 Jan 2018 11:03:04 -0500 X-Google-Smtp-Source: ACJfBovvY4G1bE9ma5CYR5cVVlT0n/N3W+R0TeZ/UqmY/R36ymSXP7dY6Ug7c6jx5cBzGV6E+eolLg== Date: Tue, 9 Jan 2018 08:02:58 -0800 From: "tj@kernel.org" To: Bart Van Assche Cc: "jbacik@fb.com" , "jack@suse.cz" , "clm@fb.com" , "axboe@kernel.dk" , "hoeppner@linux.vnet.ibm.com" , "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "linux-block@vger.kernel.org" , "sth@linux.vnet.ibm.com" , "kernel-team@fb.com" , "asamymuthupa@micron.com" , "linux-btrfs@vger.kernel.org" , "jianchao.w.wang@oracle.com" Subject: Re: [PATCH 5/8] blk-mq: make blk_abort_request() trigger timeout path Message-ID: <20180109160258.GL3668920@devbig577.frc2.facebook.com> References: <20180108191542.379478-1-tj@kernel.org> <20180108191542.379478-6-tj@kernel.org> <1515449400.2909.31.camel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515449400.2909.31.camel@wdc.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 08, 2018 at 10:10:01PM +0000, Bart Van Assche wrote: > Other req->deadline writes are protected by preempt_disable(), > write_seqcount_begin(&rq->gstate_seq), write_seqcount_end(&rq->gstate_seq) > and preempt_enable(). I think it's fine that the above req->deadline store > does not have that protection but I also think that that deserves a comment. Will add. Thanks. -- tejun