Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934119AbeAIQGG (ORCPT + 1 other); Tue, 9 Jan 2018 11:06:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52212 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933977AbeAIQGD (ORCPT ); Tue, 9 Jan 2018 11:06:03 -0500 Subject: Re: [PATCH 6/8] kvm: svm: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to guest To: Konrad Rzeszutek Wilk Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, rkrcmar@redhat.com, liran.alon@oracle.com, jmattson@google.com, aliguori@amazon.com, thomas.lendacky@amd.com, dwmw@amazon.co.uk, bp@alien8.de, x86@kernel.org References: <20180109120311.27565-1-pbonzini@redhat.com> <20180109120311.27565-7-pbonzini@redhat.com> <20180109142242.GD18661@char.us.oracle.com> From: Paolo Bonzini Message-ID: Date: Tue, 9 Jan 2018 17:05:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180109142242.GD18661@char.us.oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 09 Jan 2018 16:06:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 09/01/2018 15:22, Konrad Rzeszutek Wilk wrote: >> + have_spec_ctrl = cpu_has_spec_ctrl(); >> + if (have_spec_ctrl) >> + pr_info("kvm: SPEC_CTRL available\n"); >> + else >> + pr_info("kvm: SPEC_CTRL not available\n"); > Perhaps just > > pr_info("kvm: SPEC_CTRL %s available\n", have_spec_ctrl ? "" : "not"); > I don't expect any of these FIXMEs to be ever committed. :) Paolo