Subject: Re: [PATCH] staging: rtl8723bs: Fix trailing semicolon
To: Luis de Bethencourt <luisbg@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Bastien Nocera <hadess@hadess.net>,
        Arnd Bergmann <arnd@arndb.de>, Joe Perches <joe@perches.com>
References: <20180109150927.8720-1-luisbg@kernel.org>
 <20180109152010.GA18862@kroah.com>
 <62011a82-9412-d26d-fc19-52a873f65687@kernel.org>
From: Hans de Goede <hdegoede@redhat.com>
Message-ID: <74881576-42ba-47a8-75d4-868149bdf68e@redhat.com>
Date: Tue, 9 Jan 2018 17:11:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <62011a82-9412-d26d-fc19-52a873f65687@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

Hi,

On 09-01-18 17:02, Luis de Bethencourt wrote:
> On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote:
>> On Tue, Jan 09, 2018 at 03:09:27PM +0000, Luis de Bethencourt wrote:
>>> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
>>> ---
>>
>> I can't take patches without any changelog text, sorry :(
>>
> 
> Hi Greg,
> 
> I have done some research around previous patches to this driver and
> I am not entirely sure what you mean.
> 
> Sorry, but I need to ask before sending a v2.
> 
> Do you mind I'm missing a small summary in the commit message? Fix is
> so small I thought just the commit subject would be enough.
> 
> It is something different let me know and I will correct it.

I'm not entirely sure, but I believe Greg may have a script for this,
given the amount of mail he receives and commits without a changelog
in general not being a good idea.

What I usually do with trivial patches like this, is simply take the
part after the last : in the subject, append a "." and voila you've
a changelog txt. So in this case that would simply be:

Fix trailing semicolon.

Regards,

Hans