MIME-Version: 1.0
In-Reply-To: <4f15b6d7-6f1e-f578-2310-6dfb639b5771@redhat.com>
References: <901c4def-b0a4-42aa-9a88-cae3c3f64cf0@default> <4f15b6d7-6f1e-f578-2310-6dfb639b5771@redhat.com>
From: Jim Mattson <jmattson@google.com>
Date: Tue, 9 Jan 2018 08:40:50 -0800
Message-ID: <CALMp9eTfCtkmTjtPVb5EV0gZY38Uu=2YAN5R6_Ef0Sast7qX8g@mail.gmail.com>
Subject: Re: [PATCH 9/8] KVM: x86: limit MSR_IA32_SPEC_CTRL access based on
 CPUID availability
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Liran Alon <liran.alon@oracle.com>,
        "the arch/x86 maintainers" <x86@kernel.org>, dwmw@amazon.co.uk,
        bp@alien8.de, aliguori@amazon.com,
        Tom Lendacky <thomas.lendacky@amd.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>,
        kvm list <kvm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org

I'm going to try to get per-vCPU MSR bitmaps out today or tomorrow.

On Tue, Jan 9, 2018 at 8:11 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 09/01/2018 16:58, Liran Alon wrote:
>>
>> The only thing I a bit dislike is that currently these MSRs are always pass-through to guest and therefore
>> there is no case vmx_set_msr() is called with !msr_info->host_initiated.
>> Don't you think we should BUG_ON(!msr_info->host_initiated)?
>
> All this is in flux.  We'll probably get per-VCPU MSR bitmaps anyway
> before this patch (which is not part of the initial, minimal fix) is
> committed.
>
> Paolo
>