Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753339AbeAIQqE (ORCPT + 1 other); Tue, 9 Jan 2018 11:46:04 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45846 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259AbeAIQqD (ORCPT ); Tue, 9 Jan 2018 11:46:03 -0500 Date: Tue, 9 Jan 2018 17:46:05 +0100 From: Greg Kroah-Hartman To: Hans de Goede Cc: Luis de Bethencourt , devel@driverdev.osuosl.org, Arnd Bergmann , linux-kernel@vger.kernel.org, Bastien Nocera , Joe Perches , Larry Finger Subject: Re: [PATCH] staging: rtl8723bs: Fix trailing semicolon Message-ID: <20180109164605.GA7802@kroah.com> References: <20180109150927.8720-1-luisbg@kernel.org> <20180109152010.GA18862@kroah.com> <62011a82-9412-d26d-fc19-52a873f65687@kernel.org> <74881576-42ba-47a8-75d4-868149bdf68e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74881576-42ba-47a8-75d4-868149bdf68e@redhat.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 09, 2018 at 05:11:52PM +0100, Hans de Goede wrote: > Hi, > > On 09-01-18 17:02, Luis de Bethencourt wrote: > > On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote: > > > On Tue, Jan 09, 2018 at 03:09:27PM +0000, Luis de Bethencourt wrote: > > > > Signed-off-by: Luis de Bethencourt > > > > --- > > > > > > I can't take patches without any changelog text, sorry :( > > > > > > > Hi Greg, > > > > I have done some research around previous patches to this driver and > > I am not entirely sure what you mean. > > > > Sorry, but I need to ask before sending a v2. > > > > Do you mind I'm missing a small summary in the commit message? Fix is > > so small I thought just the commit subject would be enough. > > > > It is something different let me know and I will correct it. > > I'm not entirely sure, but I believe Greg may have a script for this, > given the amount of mail he receives and commits without a changelog > in general not being a good idea. No script for this, yet :) > What I usually do with trivial patches like this, is simply take the > part after the last : in the subject, append a "." and voila you've > a changelog txt. So in this case that would simply be: > > Fix trailing semicolon. Ick, no, come on, you can do it correctly... greg k-h