Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759636AbeAIQsZ (ORCPT + 1 other); Tue, 9 Jan 2018 11:48:25 -0500 Received: from mail-ot0-f196.google.com ([74.125.82.196]:45239 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751610AbeAIQsW (ORCPT ); Tue, 9 Jan 2018 11:48:22 -0500 X-Google-Smtp-Source: ACJfBov3u+IuP3i8VhHcrUggHmZY1QXW9BS5nVWyxPPfx8mJq2j8sLBKmw6NwCoH6cwF0L8qneHICA== Subject: Re: [PATCH][next] rtlwifi: btcoexist: remove redundant variable fw_ps_state To: Colin King , Ping-Ke Shih , Kalle Valo , Yan-Hsuan Chuang , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180109164329.15919-1-colin.king@canonical.com> From: Larry Finger Message-ID: Date: Tue, 9 Jan 2018 10:48:19 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180109164329.15919-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/09/2018 10:43 AM, Colin King wrote: > From: Colin Ian King > > Variable fw_ps_state is assigned a value but it is never read, hence > it is redundant and can be removed. Acked-by: Larry Finger Thanks, Larry > > Cleans up clang warning: > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:736:2: > warning: Value stored to 'fw_ps_state' is never read > > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c > index 5f3eda31187a..873bf9303d5d 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c > +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c > @@ -677,7 +677,7 @@ static void halbtc_display_wifi_status(struct btc_coexist *btcoexist, > u32 wifi_link_status = 0x0; > bool bt_hs_on = false, under_ips = false, under_lps = false; > bool low_power = false, dc_mode = false; > - u8 wifi_chnl = 0, wifi_hs_chnl = 0, fw_ps_state; > + u8 wifi_chnl = 0, wifi_hs_chnl = 0; > u8 ap_num = 0; > > wifi_link_status = halbtc_get_wifi_link_status(btcoexist); > @@ -733,7 +733,6 @@ static void halbtc_display_wifi_status(struct btc_coexist *btcoexist, > dc_mode = true; /*TODO*/ > under_ips = rtlpriv->psc.inactive_pwrstate == ERFOFF ? 1 : 0; > under_lps = rtlpriv->psc.dot11_psmode == EACTIVE ? 0 : 1; > - fw_ps_state = 0; > low_power = 0; /*TODO*/ > seq_printf(m, "\n %-35s = %s%s%s%s", > "Power Status", >