Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757705AbeAIRct (ORCPT + 1 other); Tue, 9 Jan 2018 12:32:49 -0500 Received: from emh02.mail.saunalahti.fi ([62.142.5.108]:36722 "EHLO emh02.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752996AbeAIRcs (ORCPT ); Tue, 9 Jan 2018 12:32:48 -0500 Date: Tue, 9 Jan 2018 19:32:40 +0200 From: Aaro Koskinen To: Arvind Yadav Cc: nsekhar@ti.com, khilman@kernel.org, linux@armlinux.org.uk, kaloz@openwrt.org, khalasa@piap.pl, tony@atomide.com, jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, gregory.clement@free-electrons.com, daniel@zonque.org, haojian.zhuang@gmail.com, marek.vasut@gmail.com, slapin@ossfans.org, jic23@cam.ac.uk, kgene@kernel.org, krzk@kernel.org, ralf@linux-mips.org, ysato@users.sourceforge.jp, dalias@libc.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 08/11 v2] ARM: OMAP1: constify gpio_led Message-ID: <20180109173240.tyh5xupjzqkxgdtu@darkstar.musicnaut.iki.fi> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Dec 26, 2017 at 12:07:11PM +0530, Arvind Yadav wrote: > gpio_led are not supposed to change at runtime. > struct gpio_led_platform_data working with const gpio_led > provided by . So mark the non-const structs > as const. > > Signed-off-by: Arvind Yadav Acked-by: Aaro Koskinen A. > --- > changes in v2: > The GPIO LED driver can be built as a module, it can > be loaded after the init sections have gone away. > So removed '__initconst'. > > arch/arm/mach-omap1/board-h2.c | 2 +- > arch/arm/mach-omap1/board-h3.c | 2 +- > arch/arm/mach-omap1/board-htcherald.c | 2 +- > arch/arm/mach-omap1/board-osk.c | 4 ++-- > 4 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-omap1/board-h2.c b/arch/arm/mach-omap1/board-h2.c > index ab51f85..9aeb8ad 100644 > --- a/arch/arm/mach-omap1/board-h2.c > +++ b/arch/arm/mach-omap1/board-h2.c > @@ -274,7 +274,7 @@ static struct platform_device h2_kp_device = { > .resource = h2_kp_resources, > }; > > -static struct gpio_led h2_gpio_led_pins[] = { > +static const struct gpio_led h2_gpio_led_pins[] = { > { > .name = "h2:red", > .default_trigger = "heartbeat", > diff --git a/arch/arm/mach-omap1/board-h3.c b/arch/arm/mach-omap1/board-h3.c > index ad339f5..2edcd63 100644 > --- a/arch/arm/mach-omap1/board-h3.c > +++ b/arch/arm/mach-omap1/board-h3.c > @@ -326,7 +326,7 @@ static struct spi_board_info h3_spi_board_info[] __initdata = { > }, > }; > > -static struct gpio_led h3_gpio_led_pins[] = { > +static const struct gpio_led h3_gpio_led_pins[] = { > { > .name = "h3:red", > .default_trigger = "heartbeat", > diff --git a/arch/arm/mach-omap1/board-htcherald.c b/arch/arm/mach-omap1/board-htcherald.c > index 67d4669..e6a79fd 100644 > --- a/arch/arm/mach-omap1/board-htcherald.c > +++ b/arch/arm/mach-omap1/board-htcherald.c > @@ -292,7 +292,7 @@ static struct platform_device herald_gpiokeys_device = { > }; > > /* LEDs for the Herald. These connect to the HTCPLD GPIO device. */ > -static struct gpio_led gpio_leds[] = { > +static const struct gpio_led gpio_leds[] = { > {"dpad", NULL, HTCPLD_GPIO_LED_DPAD, 0, 0, LEDS_GPIO_DEFSTATE_OFF}, > {"kbd", NULL, HTCPLD_GPIO_LED_KBD, 0, 0, LEDS_GPIO_DEFSTATE_OFF}, > {"vibrate", NULL, HTCPLD_GPIO_LED_VIBRATE, 0, 0, LEDS_GPIO_DEFSTATE_OFF}, > diff --git a/arch/arm/mach-omap1/board-osk.c b/arch/arm/mach-omap1/board-osk.c > index c66372e..e2277b5 100644 > --- a/arch/arm/mach-omap1/board-osk.c > +++ b/arch/arm/mach-omap1/board-osk.c > @@ -167,7 +167,7 @@ static struct platform_device *osk5912_devices[] __initdata = { > &osk5912_cf_device, > }; > > -static struct gpio_led tps_leds[] = { > +static const struct gpio_led tps_leds[] = { > /* NOTE: D9 and D2 have hardware blink support. > * Also, D9 requires non-battery power. > */ > @@ -385,7 +385,7 @@ static struct platform_device osk5912_lcd_device = { > .id = -1, > }; > > -static struct gpio_led mistral_gpio_led_pins[] = { > +static const struct gpio_led mistral_gpio_led_pins[] = { > { > .name = "mistral:red", > .default_trigger = "heartbeat", > -- > 2.7.4 >