Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934702AbeAIR6M (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Tue, 9 Jan 2018 12:58:12 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54808 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S934646AbeAIR6K (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 Jan 2018 12:58:10 -0500
Subject: Re: [PATCH v2 1/8] x86/feature: Detect the x86 IBRS feature to
 control Speculation
To: Tim Chen <tim.c.chen@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andy Lutomirski <luto@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg KH <gregkh@linuxfoundation.org>
Cc: Dave Hansen <dave.hansen@intel.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@intel.com>,
        David Woodhouse <dwmw@amazon.co.uk>,
        Borislav Petkov <bp@alien8.de>, linux-kernel@vger.kernel.org
References: <cover.1515204614.git.tim.c.chen@linux.intel.com>
 <a00d764b835898844df2b01ce506ab03e786a744.1515204614.git.tim.c.chen@linux.intel.com>
 <c1d34137-e866-24fd-e386-8beb3d4ce22a@redhat.com>
 <d20c4a33-2f06-a573-cc5c-6ae91f52b357@linux.intel.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <e2376b13-02ce-11ca-9110-35f8f561dae4@redhat.com>
Date: Tue, 9 Jan 2018 18:58:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <d20c4a33-2f06-a573-cc5c-6ae91f52b357@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 09 Jan 2018 17:58:10 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On 09/01/2018 18:53, Tim Chen wrote:
> On 01/09/2018 02:39 AM, Paolo Bonzini wrote:
> 
>> +
>> +#define MSR_IA32_SPEC_CTRL		0x00000048
>> +#define SPEC_CTRL_FEATURE_DISABLE_IBRS	(0 << 0)
>> +#define SPEC_CTRL_FEATURE_ENABLE_IBRS	(1 << 0)
> 
> 
> Boris requested that the name for ENABLE/DISABLE to be shortened to
> SPEC_CTRL_{ENABLE,DISABLE}_IBRS.  I'm planning to do that
> for the next patchset update.

Were you also planning to include KVM patches in your patchset sooner or
later?  Or would that be a separate submission?

(Either is fine; in the latter case, I assume I'll get a topic branch
from the tip tree).

>> +
>> +#define MSR_IA32_PRED_CMD		0x00000049
>> +#define PRED_CMD_IBPB			(1UL << 0)
>> +
> 
> The IBPB stuff should be enumerated separately.
> Feel free to create a separate patch for this chunk.

I think it makes sense for the patch that adds the CPU feature to also
change msr-index.h.

Paolo