Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1760271AbeAISC6 (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Tue, 9 Jan 2018 13:02:58 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:44521 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1760115AbeAISC4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 Jan 2018 13:02:56 -0500
X-Google-Smtp-Source: ACJfBosaD3iOBSq4AMoIIaJ48X387FyA63HnJ3MDZj79RORPoj5wu4Bk/oy4acUDsvZGCtg6pqri7l4QK3Is4EgFy+E=
MIME-Version: 1.0
In-Reply-To: <20180109133623.10711-2-dima@arista.com>
References: <20180109133623.10711-1-dima@arista.com> <20180109133623.10711-2-dima@arista.com>
From: Eric Dumazet <edumazet@google.com>
Date: Tue, 9 Jan 2018 10:02:53 -0800
Message-ID: <CANn89iK3M97MN0Pf3nXb+UAqqhUWOdSthHRBTYCwP75Ax_hO8Q@mail.gmail.com>
Subject: Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context
To: Dmitry Safonov <dima@arista.com>
Cc: LKML <linux-kernel@vger.kernel.org>, 0x7f454c46@gmail.com,
        Andrew Morton <akpm@linux-foundation.org>,
        David Miller <davem@davemloft.net>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Hannes Frederic Sowa <hannes@stressinduktion.org>,
        Ingo Molnar <mingo@kernel.org>,
        "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Radu Rendec <rrendec@arista.com>,
        Rik van Riel <riel@redhat.com>,
        Stanislaw Gruszka <sgruszka@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Wanpeng Li <wanpeng.li@hotmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Tue, Jan 9, 2018 at 5:36 AM, Dmitry Safonov <dima@arista.com> wrote:
> Warning: Not merge-ready
>
> I. Current workflow of ksoftirqd.
>   Softirqs are processed in the context of ksoftirqd iff they are
>   being raised very frequently. How it works:
>   do_softirq() and invoke_softirq() deffer pending softirq iff
>

...

>
>   Note, that I tested in VMs and I've found that if I produce more
>   hw irqs on the host, than the results for master are not that
>   dramatically bad, but still much worse then with RFC.
>   By that reason I have qualms if my test's results are correct.

Note that deferring all NET RX/TX to ksoftirqd is going to
dramatically hurt tail latencies.

You really should test with RPC like workloads (netperf -t TCP_RR) and
hundred of threads per cpu :/

It seems we are going to revert/adapt 4cd13c21b2 , not defer more
stuff to ksoftirqd.

Thanks