Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755338AbeAISKB (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Tue, 9 Jan 2018 13:10:01 -0500
Received: from mail.kernel.org ([198.145.29.99]:39134 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751682AbeAISKA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 Jan 2018 13:10:00 -0500
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 901D72064E
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org
Date: Tue, 9 Jan 2018 13:09:57 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Vince Weaver <vincent.weaver@maine.edu>,
        Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: perf: perf_fuzzer quickly locks up on 4.15-rc7
Message-ID: <20180109130957.52b8d9ce@vmware.local.home>
In-Reply-To: <20180109180207.GM6176@hirez.programming.kicks-ass.net>
References: <alpine.DEB.2.21.1801081105570.319@macbook-air>
        <20180108173005.lkglqrixb2ota6g2@gmail.com>
        <alpine.DEB.2.21.1801081528110.14364@macbook-air>
        <20180109102507.GG6176@hirez.programming.kicks-ass.net>
        <20180109132602.GA2369@hirez.programming.kicks-ass.net>
        <alpine.DEB.2.21.1801090841300.15884@macbook-air>
        <20180109151253.GK6176@hirez.programming.kicks-ass.net>
        <20180109161400.GC2369@hirez.programming.kicks-ass.net>
        <20180109125346.17cad4a5@vmware.local.home>
        <20180109180207.GM6176@hirez.programming.kicks-ass.net>
X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Tue, 9 Jan 2018 19:02:07 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

> This would globally serialize all perf_ioctl()'s, also that event_mutex
> is for trace_events and really does not belong in perf.
> 
> So no, I really rather would not do this.
> 
> The alternative I was thinking of was lifting the cpuhp lock out from
> under event_mutex, that would also break the chain, but would probably
> be lots of work for trace bits.

I think we tried that once, and it became an never ending whack a mole
process. I prefer not to do that either. 

How bad is your work around patch that you posted?

-- Steve