Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760448AbeAISwv (ORCPT + 1 other); Tue, 9 Jan 2018 13:52:51 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:36228 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760424AbeAISwq (ORCPT ); Tue, 9 Jan 2018 13:52:46 -0500 X-Google-Smtp-Source: ACJfBovV1Hu8VyTdu2oGwBeClx7QwtHAq0xJAQKikJxU5t0GQYxorhj5dxuRO4DU9Wy4GQxhlOgmSw== Cc: mtk.manpages@gmail.com, "Serge E. Hallyn" , Tejun Heo , linux-man , lkml , cgroups@vger.kernel.org Subject: Re: cgroups(7): documenting /sys/kernel/cgroup files To: Roman Gushchin References: <20180109112811.GA31373@castle.DHCP.thefacebook.com> From: "Michael Kerrisk (man-pages)" Message-ID: <7e64c6a5-123f-0341-7f35-c9b616c48322@gmail.com> Date: Tue, 9 Jan 2018 19:52:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180109112811.GA31373@castle.DHCP.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hello ROman, On 01/09/2018 12:28 PM, Roman Gushchin wrote: > Hello, Michael! > > Overall looks good to me, one small nit below. > > On Mon, Jan 08, 2018 at 10:11:43PM +0100, Michael Kerrisk (man-pages) wrote: >> Hello Roman, >> >> I wrote cgroups(7) text below to document the files added by you in >> Linux 4.15. Could you let me know if the following text is okay please: >> >> /sys/kernel/cgroup files >> /sys/kernel/cgroup/delegate (since Linux 4.15) >> This file exports a list of the cgroups v2 files (one per >> line) that are delegatable (i.e., whose ownership should be >> changed to the user ID of the delegatee). In the future, >> the set of delegatable files may change or grow, and this >> file provides a way for the kernel to inform user-space >> applications of which files must be delegated. As at Linux >> 4.15, one sees the following when inspecting this file: >> >> $ cat /sys/kernel/cgroup/delegate >> cgroup.procs >> cgroup.subtree_control >> >> /sys/kernel/cgroup/features (since Linux 4.15) >> Over time, the set of cgroups v2 features that are provided >> by the kernel may change or grow, or some features may not >> be enabled by default. This file provides a way for user- >> space applications to discover what features the running >> kernel supports or has enabled. Features are listed one > ^^ > I would replace "or" with "and" here. Yes. Done. > Please, feel free to add > Reviewed-by: Roman Gushchin Thanks! Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/