Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933892AbeAITLk (ORCPT + 1 other); Tue, 9 Jan 2018 14:11:40 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:34324 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933073AbeAITLi (ORCPT ); Tue, 9 Jan 2018 14:11:38 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BC64F601C4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=clew@codeaurora.org Subject: Re: [PATCH 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings To: Stephen Boyd , Bjorn Andersson , Rob Herring Cc: andy.gross@linaro.org, david.brown@linaro.org, aneela@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1513634534-22861-1-git-send-email-clew@codeaurora.org> <1513634534-22861-2-git-send-email-clew@codeaurora.org> <20171220183000.rhxgyikfqzxmqkjo@rob-hp-laptop> <20171221013557.GE12655@minitux> From: Chris Lew Message-ID: <24be93c8-d09e-5250-d654-d5f7a24c094b@codeaurora.org> Date: Tue, 9 Jan 2018 11:11:36 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 12/21/2017 11:36 AM, Stephen Boyd wrote: > On 12/20/2017 05:35 PM, Bjorn Andersson wrote: >> On Wed 20 Dec 10:30 PST 2017, Rob Herring wrote: >> >>> On Mon, Dec 18, 2017 at 02:02:09PM -0800, Chris Lew wrote: >>>> Add a label property to identify the edge this node represents. >>> Why does a user need to know this? >>> >> We have multiple remoteproc instances, each one having one or more >> associated SMD or GLINK links (this node), exposing logical >> communication channels. Some of these logical channels are exposed to >> user space and we need a way to distinguish them there. >> >> In the current implementation of SMD this value goes straight into an >> sysfs attribute that we can use when writing udev rules and for the DIAG >> implementation to pair up channels related to the same remoteproc. This >> adds the equivalent information for glink-backed channels. >> >> >> I'm therefor in favor of picking this patch. > > Please add these details to the commit log. Just writing what the patch > is doing isn't very helpful. > Ok, will do. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project