Date: Tue, 9 Jan 2018 20:53:19 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Vince Weaver <vincent.weaver@maine.edu>,
        Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: perf: perf_fuzzer quickly locks up on 4.15-rc7
Message-ID: <20180109195319.GN6176@hirez.programming.kicks-ass.net>
References: <20180108173005.lkglqrixb2ota6g2@gmail.com>
 <alpine.DEB.2.21.1801081528110.14364@macbook-air>
 <20180109102507.GG6176@hirez.programming.kicks-ass.net>
 <20180109132602.GA2369@hirez.programming.kicks-ass.net>
 <alpine.DEB.2.21.1801090841300.15884@macbook-air>
 <20180109151253.GK6176@hirez.programming.kicks-ass.net>
 <20180109161400.GC2369@hirez.programming.kicks-ass.net>
 <20180109125346.17cad4a5@vmware.local.home>
 <20180109180207.GM6176@hirez.programming.kicks-ass.net>
 <20180109130957.52b8d9ce@vmware.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180109130957.52b8d9ce@vmware.local.home>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org

On Tue, Jan 09, 2018 at 01:09:57PM -0500, Steven Rostedt wrote:
> On Tue, 9 Jan 2018 19:02:07 +0100
> Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > This would globally serialize all perf_ioctl()'s, also that event_mutex
> > is for trace_events and really does not belong in perf.
> > 
> > So no, I really rather would not do this.
> > 
> > The alternative I was thinking of was lifting the cpuhp lock out from
> > under event_mutex, that would also break the chain, but would probably
> > be lots of work for trace bits.
> 
> I think we tried that once, and it became an never ending whack a mole
> process. I prefer not to do that either. 

Figures..

> How bad is your work around patch that you posted?

Not too bad, just tricky..