Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759004AbeAIXZi (ORCPT + 1 other); Tue, 9 Jan 2018 18:25:38 -0500 Received: from mail-ua0-f194.google.com ([209.85.217.194]:44457 "EHLO mail-ua0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753895AbeAIXZg (ORCPT ); Tue, 9 Jan 2018 18:25:36 -0500 X-Google-Smtp-Source: ACJfBovF9EsPVWBm42TXOpCLE0QkQD1yQFwOYP3WMO2EM/xUOj/QznnaLqGmhwweehM8M9jJ1TsewNkj8P/RVkiSgJc= MIME-Version: 1.0 In-Reply-To: References: <20180105163118.22598-1-anders.roxell@linaro.org> From: Kees Cook Date: Tue, 9 Jan 2018 15:25:35 -0800 X-Google-Sender-Auth: dfGq2-EC9JBY54Zb5bqqy3WJbvw Message-ID: Subject: Re: [PATCH] selftests: seccomp: fix compile error seccomp_bpf To: Naresh Kamboju , Shuah Khan Cc: Anders Roxell , "open list:KERNEL SELFTEST FRAMEWORK" , LKML , Will Drewry , Andy Lutomirski Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 9, 2018 at 3:24 PM, Kees Cook wrote: > On Tue, Jan 9, 2018 at 3:07 PM, Kees Cook wrote: >> On Fri, Jan 5, 2018 at 6:29 PM, Naresh Kamboju >> wrote: >>> On 5 January 2018 at 22:01, Anders Roxell wrote: >>>> aarch64-linux-gnu-gcc -Wl,-no-as-needed -Wall >>>> -lpthread seccomp_bpf.c -o seccomp_bpf >>>> seccomp_bpf.c: In function 'tracer_ptrace': >>>> seccomp_bpf.c:1720:12: error: '__NR_open' undeclared >>>> (first use in this function) >>>> if (nr == __NR_open) >>>> ^~~~~~~~~ >>>> seccomp_bpf.c:1720:12: note: each undeclared identifier is reported >>>> only once for each function it appears in >>>> In file included from seccomp_bpf.c:48:0: >>>> seccomp_bpf.c: In function 'TRACE_syscall_ptrace_syscall_dropped': >>>> seccomp_bpf.c:1795:39: error: '__NR_open' undeclared >>>> (first use in this function) >>>> EXPECT_SYSCALL_RETURN(EPERM, syscall(__NR_open)); >>>> ^ >>>> open(2) is a legacy syscall, replaced with openat(2) since 2.6.16. >>>> Thus new architectures in the kernel, such as arm64, don't implement >>>> these legacy syscalls. >>>> >>>> Signed-off-by: Anders Roxell >>> >>> Thanks for the patch Anders. >>> Tested-by: Naresh Kamboju >> >> Did something change recently? This has built fine on arm64 for a >> while -- at least since commit 256d0afb11d6 ("selftests/seccomp: build >> and pass on arm64"). > > Ah, found it. I broke it in a33b2d0359a0! :) Shuah, can you take this > please, with this tag added: > > Fixes: a33b2d0359a0 ("selftests/seccomp: Add tests for basic ptrace actions") And Cc to stable, as this was broken in 4.14... Cc: stable@vger.kernel.org -Kees -- Kees Cook Pixel Security