Date: Tue, 9 Jan 2018 15:37:03 -0800
From: Guenter Roeck <linux@roeck-us.net>
To: Lyude Paul <lyude@redhat.com>
Cc: Wim Van Sebroeck <wim@iguana.be>, linux-watchdog@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        =?iso-8859-1?B?Wm9sdOFuIEL2c3r2cm3pbnlp?= <zboszor@pr.hu>
Subject: Re: [11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by
 hardware
Message-ID: <20180109233703.GD26819@roeck-us.net>
References: <1514149457-20273-12-git-send-email-linux@roeck-us.net>
 <1515538687.4373.18.camel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1515538687.4373.18.camel@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org

Hi,

On Tue, Jan 09, 2018 at 05:58:07PM -0500, Lyude Paul wrote:
> Hi! I'm the one from the Fedora bugzilla who said they'd help review these
> patches. I might end up responding to this with a real review comment after
> this message, but first:
> 
> mind cc'ing me future versions of this patchset and also, is there any way you

Sure.

> know of that one could figure out whether or not the sp5100_tco wdt is
> actually disabled by the OEM on a board? I tried testing these patches with my

That is what the code is trying to do today.

> system and it appears to be convinced that it's disabled on my system, but I'm
> hoping something in this patch is just broken…
> 

I tested the driver on three different boards. MSI B350M MORTAR,
MSI B350 TOMAHAWK, and Gigabyte AB350M-Gaming 3. CPU is Ryzen 1700X
on all boards.

On the MSI boards, the watchdog is reported as disabled. Enabling it
and letting it expire does not have an effect. I am using the Super-IO
watchdog instead on those boards (and it works).

On the Gigabyte board, the watchdog is reported as enabled, and it works
(and the watchdog on the Super-IO chips does not work).

Feel free to play with the driver. Maybe there is a means to enable the
watchdog if it is disabled. Unfortunately, I was unable to figure out how
to do it, so I thought it is better to report the fact and not instantiate
the watchdog if it doesn't work.

Hope this helps,
Guenter