Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520AbeAIX6G (ORCPT + 1 other); Tue, 9 Jan 2018 18:58:06 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:46557 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbeAIX6E (ORCPT ); Tue, 9 Jan 2018 18:58:04 -0500 X-Google-Smtp-Source: ACJfBosEN5L25Ie03tawPVoN81FPTPbvLcqUrDXrMVLDspbMSBz9HCTRpvFA9OiWsWva9XoEzhtccw== Subject: Re: [11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware To: Guenter Roeck , Lyude Paul Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?B?Wm9sdMOhbiBCw7ZzesO2cm3DqW55aQ==?= References: <1514149457-20273-12-git-send-email-linux@roeck-us.net> <1515538687.4373.18.camel@redhat.com> <20180109233703.GD26819@roeck-us.net> From: Gabriel C Message-ID: <4b56f6ba-bf76-a500-087a-49f34cd4b5d5@gmail.com> Date: Wed, 10 Jan 2018 00:58:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180109233703.GD26819@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 10.01.2018 00:37, Guenter Roeck wrote: > Hi, > > On Tue, Jan 09, 2018 at 05:58:07PM -0500, Lyude Paul wrote: >> Hi! I'm the one from the Fedora bugzilla who said they'd help review these >> patches. I might end up responding to this with a real review comment after >> this message, but first: >> >> mind cc'ing me future versions of this patchset and also, is there any way you > > Sure. > >> know of that one could figure out whether or not the sp5100_tco wdt is >> actually disabled by the OEM on a board? I tried testing these patches with my > > That is what the code is trying to do today. > >> system and it appears to be convinced that it's disabled on my system, but I'm >> hoping something in this patch is just broken… >> > > I tested the driver on three different boards. MSI B350M MORTAR, > MSI B350 TOMAHAWK, and Gigabyte AB350M-Gaming 3. CPU is Ryzen 1700X > on all boards. > > On the MSI boards, the watchdog is reported as disabled. Enabling it > and letting it expire does not have an effect. I am using the Super-IO > watchdog instead on those boards (and it works). > > On the Gigabyte board, the watchdog is reported as enabled, and it works > (and the watchdog on the Super-IO chips does not work). > > Feel free to play with the driver. Maybe there is a means to enable the > watchdog if it is disabled. Unfortunately, I was unable to figure out how > to do it, so I thought it is better to report the fact and not instantiate > the watchdog if it doesn't work. > I haven an Supemricro H11DSi-NT with EPYCs CPUs.. I can set the watchdog ON/OFF in BIOS and also set in to reset or NMI with the moatherboard jumpers. If you want I can give whatever patches for this driver an try , just let me know. Regards, Gabriel C