Subject: Re: [PATCH v1 1/2] x86/retpoline: Add a function to clear the
 RETPOLINE_AMD feature
To: Thomas Gleixner <tglx@linutronix.de>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
        Rik van Riel <riel@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jiri Kosina <jikos@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Borislav Petkov <bp@alien8.de>,
        Andy Lutomirski <luto@kernel.org>,
        Kees Cook <keescook@google.com>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linux-foundation.org>,
        David Woodhouse <dwmw@amazon.co.uk>,
        Paul Turner <pjt@google.com>
References: <20180109223723.29322.59126.stgit@tlendack-t1.amdoffice.net>
 <20180109223736.29322.5436.stgit@tlendack-t1.amdoffice.net>
 <alpine.DEB.2.20.1801092345560.2200@nanos>
 <12147db9-e975-268f-55ee-247868e0e0d8@amd.com>
 <alpine.DEB.2.20.1801100004040.2200@nanos>
 <a366ccaf-736d-225a-5eb9-bcbcd6251d47@amd.com>
 <alpine.DEB.2.20.1801100040240.2200@nanos>
From: Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <ec9d4e6e-f6d9-1001-ed2e-ae242de88944@amd.com>
Date: Tue, 9 Jan 2018 18:22:39 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1801100040240.2200@nanos>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2018 00:22:42.5879 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 48cee1df-1c1f-4756-a557-08d557c0446b
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1139
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On 1/9/2018 5:43 PM, Thomas Gleixner wrote:
> On Tue, 9 Jan 2018, Tom Lendacky wrote:
>> On 1/9/2018 5:09 PM, Thomas Gleixner wrote:
>>> On Tue, 9 Jan 2018, Tom Lendacky wrote:
>>>> On 1/9/2018 4:46 PM, Thomas Gleixner wrote:
>>>>> Urgh. That's an awful hack. why not do the obvious?
>>>>
>>>> My first attempt was very similar to your change below, but testing
>>>> showed that spectre_v2_check_boottime_disable() is called before the
>>>> X86_FEATURE_LFENCE_RDTSC can be set.  I can look at moving where the
>>>> X86_FEATURE_LFENCE_RDTSC is set, maybe into early_init_amd() or such
>>>> if you think that would be best.
>>>
>>> Wait, we can move the selection _AFTER_ identify_boot_cpu().
>>
>> Much cleaner.  Since it's just a single patch now, do you want me to
>> re-submit this after I test it or will you just pick this up as is?
>>
>> I did notice that the patch does change the behavior associated with
>> the command line options, though.  Not sure if that was intentional.
> 
> Yes. I noticed while looking at your issue that when AMD is selected on the
> command line then we have no support at all on intel. So I prefer to err
> out and enable the generic version.
> 
> If you can just polish it up with a changelog and resubmit after testing
> that would be appreciated as I'm steam blasting the IBRS stuff at the
> moment.

Will do.  I'll add your Signed-off-by when I submit it.

Thanks,
Tom

> 
> Thanks,
> 
> 	tglx
>