Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756706AbeAJDva (ORCPT + 1 other); Tue, 9 Jan 2018 22:51:30 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:42612 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755326AbeAJDvZ (ORCPT ); Tue, 9 Jan 2018 22:51:25 -0500 X-Google-Smtp-Source: ACJfBoup5Vjo6vn21kCdZHi2aycMxHPmHlhnAppHD31T+6bGfZZi3DO9fRmYwT79ue3OYYJnS9nESApYg6GQce8wgSI= MIME-Version: 1.0 In-Reply-To: References: <1514556006-23293-1-git-send-email-mastichi@gmail.com> <20171229175449.760e734d@archlinux> <20180101095342.4d4d5325@archlinux> <20180106131434.550e8e42@archlinux> <20180107160820.05660804@archlinux> From: Dmitry Mastykin Date: Wed, 10 Jan 2018 06:51:23 +0300 Message-ID: Subject: Re: [PATCH v2] iio: adc: max9611: fix module auto-loading To: Jonathan Cameron Cc: Andy Shevchenko , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jacopo Mondi , Dan Carpenter , Rob Herring , linux-iio@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hello Johnatan, May be the issue is the same as Javier Martinez Canillas wrote: "What is not correct is to require OF-only drivers to have an I2C device ID table just as a workaround to have their modules auto-loading working." Please see: http://lkml.iu.edu/hypermail/linux/kernel/1712.0/01779.html So the problem is not in driver, but in auto-loading procedure. Thank you! Kind regards, Dmitry >>> >> >> >> > Signed-off-by: Dmitry Mastykin >>> >> >> >> > --- >>> >> >> >> > drivers/iio/adc/max9611.c | 5 ++--- >>> >> >> >> > 1 file changed, 2 insertions(+), 3 deletions(-) >>> >> >> >> > >>> >> >> >> > diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c >>> >> >> >> > index b1dd17c..ce0115a 100644 >>> >> >> >> > --- a/drivers/iio/adc/max9611.c >>> >> >> >> > +++ b/drivers/iio/adc/max9611.c >>> >> >> >> > @@ -523,8 +523,7 @@ static const struct of_device_id max9611_of_table[] = { >>> >> >> >> > }; >>> >> >> >> > >>> >> >> >> > MODULE_DEVICE_TABLE(of, max9611_of_table); >>> >> >> >> > -static int max9611_probe(struct i2c_client *client, >>> >> >> >> > - const struct i2c_device_id *id) >>> >> >> >> > +static int max9611_probe(struct i2c_client *client) >>> >> >> >> > { >>> >> >> >> > const char * const shunt_res_prop = "shunt-resistor-micro-ohms"; >>> >> >> >> > const struct device_node *of_node = client->dev.of_node; >>> >> >> >> > @@ -576,7 +575,7 @@ static struct i2c_driver max9611_driver = { >>> >> >> >> > .owner = THIS_MODULE, >>> >> >> >> > .of_match_table = max9611_of_table, >>> >> >> >> > }, >>> >> >> >> > - .probe = max9611_probe, >>> >> >> >> > + .probe_new = max9611_probe, >>> >> >> >> > }; >>> >> >> >> > module_i2c_driver(max9611_driver); >>> >> >> >> > >>> >> >> >> > -- >>> >> >> >> > 2.7.4 >>> >> >> >> > >>> >> > >>> > >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>