Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757138AbeAJEjZ (ORCPT + 1 other); Tue, 9 Jan 2018 23:39:25 -0500 Received: from mga02.intel.com ([134.134.136.20]:44329 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754054AbeAJEjY (ORCPT ); Tue, 9 Jan 2018 23:39:24 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,338,1511856000"; d="scan'208";a="8610282" Subject: Re: [v7, 05/11] x86/retpoline/entry: Convert entry assembler indirect jumps To: Andi Kleen , Andrei Vagin References: <1515508997-6154-6-git-send-email-dwmw@amazon.co.uk> <20180110035407.GA16912@outlook.office365.com> <20180110043010.GJ6718@tassilo.jf.intel.com> Cc: "Woodhouse, David" , Paul Turner , LKML , Linus Torvalds , Greg Kroah-Hartman , Tim Chen , tglx@linutronix.de, Kees Cook , Rik van Riel , Peter Zijlstra , Andy Lutomirski , Jiri Kosina , gnomes@lxorguk.ukuu.org.uk, x86@kernel.org From: Dave Hansen Message-ID: Date: Tue, 9 Jan 2018 20:39:21 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180110043010.GJ6718@tassilo.jf.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/09/2018 08:30 PM, Andi Kleen wrote: > On Tue, Jan 09, 2018 at 07:54:08PM -0800, Andrei Vagin wrote: >> >> In my test environment, the kernel with this patch crashes. > > I posted a patch for this. It's called: [PATCH v3 2/3] x86/retpoline: Use better sequences for NOSPEC_CALL/JMP right, Andi? BTW, that's a fun oops. It looks like it's call'ing (or jumping) to an address that's used by cpu_entry_area->exception_stacks[1].