Date: Wed, 10 Jan 2018 14:45:07 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Tom Zanussi <tom.zanussi@linux.intel.com>
Cc: rostedt@goodmis.org, tglx@linutronix.de, mhiramat@kernel.org,
        vedang.patel@intel.com, bigeasy@linutronix.de,
        joel.opensrc@gmail.com, joelaf@google.com,
        mathieu.desnoyers@efficios.com, baohong.liu@intel.com,
        rajvi.jingar@intel.com, julia@ni.com, fengguang.wu@intel.com,
        linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
        kernel-team@lge.com
Subject: Re: [PATCH v8 00/37] tracing: Inter-event (e.g. latency) support
Message-ID: <20180110054507.GB2575@danjae.aot.lge.com>
References: <cover.1513802700.git.tom.zanussi@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1513802700.git.tom.zanussi@linux.intel.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org

On Thu, Dec 21, 2017 at 10:02:22AM -0600, Tom Zanussi wrote:
> Hi,
> 
> This is V8 of the inter-event tracing patchset, addressing input from
> V7.
> 
> These changes address Namhyung's most recent comments (thanks,
> Namhyung!) and move everything to the latest tracing/for-next:
> 
>   - moved a couple hunks switching hist_field_fn_t params from 15/37
>     (add variable support) to 20/37 (Pass tracing_map_elt to
>     hist_field_accessor)
>   - in hist_trigger_elt_data_alloc(), remove the unnecessary '+1' from
>     TASK_COMM_LEN size.
>   - simplified find_var_file() code according to Namhyung's
>     suggestions.
>   - fixed bug in print_synth_event() where entry->fields was being
>     used instead of the address as it should have been

I only have a nitpick in the patch 24 but otherwise cannot find an
issue anymore, so

Reviewed-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung