Date: Wed, 10 Jan 2018 07:20:13 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linuxfoundation.org>, x86@kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Borislav Petkov <bp@alien8.de>,
        David Woodhouse <dwmw@amazon.co.uk>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Andy Lutomirski <luto@kernel.org>,
        Arjan Van De Ven <arjan.van.de.ven@intel.com>,
        Borislav Petkov <bp@suse.de>,
        "Raj, Ashok" <ashok.raj@intel.com>
Subject: Re: [patch RFC 1/5] x86/CPU: Sync CPU feature flags late
Message-ID: <20180110062013.47tbgtccf2wgp5td@gmail.com>
References: <20180110010652.404145126@linutronix.de>
 <20180110011350.501418723@linutronix.de>
 <f70ea6ad-d563-5f60-2657-0551249a70e6@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f70ea6ad-d563-5f60-2657-0551249a70e6@intel.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org

* Dave Hansen <dave.hansen@intel.com> wrote:

> On 01/09/2018 05:06 PM, Thomas Gleixner wrote:
> > This is for the case where we need to set feature flags late, like, for
> > example, after late microcode patch has been loaded which has enabled
> > new CPUID bits.
> > 
> > This has no effect on alternatives patching.
> 
> In other words, if you use late microcode loading for getting IBRS, you
> don't get ALTERNATIVE patching and its benefits?
> 
> I'll also profess some microcode ignorance here.  Is "late microcode
> patching" *all* of the stuff we do from the OS, or do we have early and
> late Linux loading in addition to what the BIOS can do?

So would it be really unreasonable to say that if a microcode update changes CPU 
flags an initrd rebuild and a reboot is required? It's not like microcode updates 
are _that_ frequent - in fact they tend to be much _less_ frequent in a system's 
life time than kernel updates.

So all of this 'late loading' and CPU flag splitting complexity seems unnecessary 
to me: we should be glad we do early microcode loading now, and should embrace it.

Changing CPU features way after the CPU has booted up is possible, and we could in 
theory extend code patching to work 'late' as well, but given how infrequent all 
this is bound to be in practice I fear it's all going to be a big, seldom tested, 
often broken mess, with no real benefit to users.

Thanks,

	Ingo