Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932131AbeAJHQ3 (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Wed, 10 Jan 2018 02:16:29 -0500
Received: from mail-wr0-f178.google.com ([209.85.128.178]:38895 "EHLO
        mail-wr0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751954AbeAJHQ2 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 Jan 2018 02:16:28 -0500
X-Google-Smtp-Source: ACJfBotVVkTZ/j54+6uUkvDOrIKAuX6Jwy/4z/KHPEOk6q9RNVM0nGwZcfJ0L/QYGPn4UlHTIjjb+A==
Date: Wed, 10 Jan 2018 08:16:24 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Willy Tarreau <w@1wt.eu>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
        Andy Lutomirski <luto@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Brian Gerst <brgerst@gmail.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Kees Cook <keescook@chromium.org>
Subject: Re: [RFC PATCH v2 5/6] x86/entry/pti: avoid setting CR3 when it's
 already correct
Message-ID: <20180110071624.gllkdls2eo7jfhaf@gmail.com>
References: <1515502580-12261-1-git-send-email-w@1wt.eu>
 <1515502580-12261-6-git-send-email-w@1wt.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1515502580-12261-6-git-send-email-w@1wt.eu>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>


* Willy Tarreau <w@1wt.eu> wrote:

> +	/* if we're already on the kernel PGD, we don't switch */
> +	 * If we're already on the kernel PGD, we don't switch,
> +	 * If we saved a kernel context on entry, we didn't switch the CR3,

It's hard enough to read assembly code, please use consistent capitalization:

s/if
 /If

Thanks,

	Ingo