Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754198AbeAJHy1 (ORCPT + 1 other); Wed, 10 Jan 2018 02:54:27 -0500 Received: from mail-pl0-f49.google.com ([209.85.160.49]:39500 "EHLO mail-pl0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754047AbeAJHy0 (ORCPT ); Wed, 10 Jan 2018 02:54:26 -0500 X-Google-Smtp-Source: ACJfBov8Vj72zCOZ0XzPegpjrGnTMlAs7NUL5ox0DSM5qQ3fCQRjeCZyq7R693PoZoAEgWyydqS3zQ== Date: Wed, 10 Jan 2018 15:54:20 +0800 From: Alan Kao To: Christoph Hellwig Cc: Palmer Dabbelt , Albert Ou , Steven Rostedt , Ingo Molnar , Masahiro Yamada , Kamil Rytarowski , Andrew Morton , patches@groups.riscv.org, linux-kernel@vger.kernel.org, Alan Kao , Greentime Hu Subject: Re: [patches] [PATCH 1/6] riscv/ftrace: Add RECORD_MCOUNT support Message-ID: <20180110075418.GA32418@93d8b218059b> References: <20180110073814.32338-1-alankao@andestech.com> <20180110073814.32338-2-alankao@andestech.com> <20180110074354.GA8800@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180110074354.GA8800@lst.de> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 10, 2018 at 08:43:54AM +0100, Christoph Hellwig wrote: > On Wed, Jan 10, 2018 at 03:38:09PM +0800, Alan Kao wrote: > > -LDFLAGS_vmlinux := > > +ifeq ($(CONFIG_DYNAMIC_FTRACE),y) > > + LDFLAGS_vmlinux := --no-relax > > +else > > + LDFLAGS_vmlinux := > > +endif > > Why not: > > LDFLAGS_vmlinux := > ifeq ($(CONFIG_DYNAMIC_FTRACE),y) > LDFLAGS_vmlinux += --no-relax > endif > Thanks for the comment! This will be enhanced in the next try. Alan