Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751356AbeAJIbx (ORCPT + 1 other); Wed, 10 Jan 2018 03:31:53 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:54555 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506AbeAJIbt (ORCPT ); Wed, 10 Jan 2018 03:31:49 -0500 From: Gregory CLEMENT To: Chris Packham Cc: jlu@pengutronix.de, linux@armlinux.org.uk, bp@alien8.de, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Mark Rutland , devicetree@vger.kernel.org Subject: Re: [PATCH 2/3] ARM: dts: mvebu: add sdram controller node to Armada-38x References: <20180108223158.21930-1-chris.packham@alliedtelesis.co.nz> <20180108223158.21930-3-chris.packham@alliedtelesis.co.nz> Date: Wed, 10 Jan 2018 09:31:37 +0100 In-Reply-To: <20180108223158.21930-3-chris.packham@alliedtelesis.co.nz> (Chris Packham's message of "Tue, 9 Jan 2018 11:31:57 +1300") Message-ID: <87tvvu6ro6.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Chris, On mar., janv. 09 2018, Chris Packham wrote: > The Armada-38x uses an SDRAM controller that is compatible with the > Armada-XP. The key difference is the width of the bus (XP is 64/32, 38x > is 32/16). The SDRAM controller registers are the same between the two > SoCs. > > Signed-off-by: Chris Packham > --- > arch/arm/boot/dts/armada-38x.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi > index 00ff549d4e39..6d34c5ec178f 100644 > --- a/arch/arm/boot/dts/armada-38x.dtsi > +++ b/arch/arm/boot/dts/armada-38x.dtsi > @@ -138,6 +138,11 @@ > #size-cells = <1>; > ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>; > > + sdramc@1400 { Could you add a label? Thanks to this it would be possible to enable/disable it at board level in a esay way. > + compatible = "marvell,armada-xp-sdram-controller"; > + reg = <0x1400 0x500>; What about adding status = "disabled" ? Thanks to this we can enable it at board level only if we really want it, it would avoid nasty regression on boards that don't need it, if an issue occurs. Unless you are sure that it is completely safe to enable it for everyone. Thanks, Gregory > + }; > + > L2: cache-controller@8000 { > compatible = "arm,pl310-cache"; > reg = <0x8000 0x1000>; > -- > 2.15.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com