Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964872AbeAJIeY (ORCPT + 1 other); Wed, 10 Jan 2018 03:34:24 -0500 Received: from mail6.pr.hu ([87.242.0.6]:52978 "EHLO mail6.pr.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754271AbeAJIeV (ORCPT ); Wed, 10 Jan 2018 03:34:21 -0500 Subject: Re: [PATCH 12/12] watchdog: sp5100_tco: Add support for recent FCH versions To: Guenter Roeck Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Lyude Paul References: <1514149457-20273-1-git-send-email-linux@roeck-us.net> <1514149457-20273-13-git-send-email-linux@roeck-us.net> <9bac4f60-e385-fef8-0a8f-7a473b079055@pr.hu> <20180104192114.GA28864@roeck-us.net> From: Boszormenyi Zoltan Message-ID: Date: Wed, 10 Jan 2018 09:34:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180104192114.GA28864@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scan-Signature: f0c4dd17e446f11bd1554530b2f50cce Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: I'm trying to remove non-ASCII chars from the mail body in the hope it reaches the lists... My ISP still adds that X-Spam-Report: header quoting large part of the mail body without MIME-encoding it. On 2018-01-04 20:21, Guenter Roeck wrote: > On Thu, Jan 04, 2018 at 01:01:22PM +0100, Boszormenyi Zoltan wrote: >> On 2017-12-24 22:04, Guenter Roeck wrote: >>> Starting with Family 16h Models 30h-3Fh and Family 15h Models 60h-6Fh, >>> watchdog address space decoding has changed. The cutover point is already >>> identified in the i2c-piix2 driver, so use the same mechanism. >> >> "i2c-piix4". >> > Thanks! > >> Otherwise, I only have an older AMD FX CPU, so I can only test >> whether it is not broken there. >> > > That is actually the important test. I tested myself on Ryzen 1700X. I was able to test on a Kabini APU at work, my AMD FX at home still needs to be tested. The driver loads properly: [ 5.620836] sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver [ 5.621002] sp5100-tco sp5100-tco: Using 0xfed80b00 for watchdog MMIO address [ 5.621611] sp5100-tco sp5100-tco: initialized. heartbeat=60 sec (nowayout=1) echo "1" >/dev/watchdog rebooted the machine after one minute properly. You can add my Tested-by: line. Best regards, Zoltan Boszormenyi