Date: Wed, 10 Jan 2018 09:50:37 +0100
From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: Johan Hovold <johan@kernel.org>, gregkh@linuxfoundation.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        peter_hong@fintek.com.tw,
        "Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V2 5/5] usb: serial: f81534: fix tx error on some baud
 rate
Message-ID: <20180110085037.GW11344@localhost>
References: <1515032961-29131-1-git-send-email-hpeter+linux_kernel@gmail.com>
 <1515032961-29131-5-git-send-email-hpeter+linux_kernel@gmail.com>
 <20180109113216.GR11344@localhost>
 <747ab8c9-50cc-2bbb-6f58-758e3361cbe2@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <747ab8c9-50cc-2bbb-6f58-758e3361cbe2@gmail.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org

On Wed, Jan 10, 2018 at 01:42:32PM +0800, Ji-Ze Hong (Peter Hong) wrote:
> Hi Johan,
> 
> Johan Hovold 於 2018/1/9 下午 07:32 寫道:
> > On Thu, Jan 04, 2018 at 10:29:21AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> >> +	/*
> >> +	 * We'll make tx frame error when baud rate from 384~500kps. So we'll
> >> +	 * delay all tx data frame with 1bit.
> >> +	 */
> >> +	port_priv->shadow_clk |= F81534_CLK_TX_DELAY_1BIT;
> > 
> > You don't wan't to enable this only for the affected rates?
> > 
> 
> This bit will control all transmit TX frame always delay 1 bit
> on enabled, but It'll transmit TX frame randomly delay 1 bit on
> disabled.
> 
> We had tested it with BurnInTest to check the performance,
> It'll not make the performance regression. So we'll directly add
> it on all baud rate.

Ok, thanks for confirming.

Johan