Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754006AbeAJJt2 (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Wed, 10 Jan 2018 04:49:28 -0500
Received: from dd39320.kasserver.com ([85.13.155.146]:34426 "EHLO
        dd39320.kasserver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753072AbeAJJt0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 Jan 2018 04:49:26 -0500
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
X-SenderIP: 108.171.129.168
User-Agent: ALL-INKL Webmail 2.11
In-Reply-To: <1515575145.9619.146.camel@perches.com>
References: <20180108173855.19366-1-Valentin.Vidic@CARNet.hr> <20180109143148.GB608@kroah.com> <1515525697.9619.100.camel@perches.com> <20180109192844.GB20280@kroah.com> <1515526936.9619.121.camel@perches.com> <20180110084414.GA10805@kroah.com><1515575145.9619.146.camel@perches.com>
Subject: Re: [PATCH] staging: pi433: remove unnecessary parentheses
From: marcus.wolf@smarthome-wolf.de
To: gregkh@linuxfoundation.org, joe@perches.com
Cc: Valentin.Vidic@CARNet.hr, davem@davemloft.net,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        marcin.s.ciupak@gmail.com, linux@wolf-entwicklungen.de,
        simon@nikanor.nu
Message-Id: <20180110094923.C78122CE00CD@dd39320.kasserver.com>
Date: Wed, 10 Jan 2018 10:49:23 +0100 (CET)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

Joe Perches schrieb am 10.01.2018 10:05:
> On Wed, 2018-01-10 at 09:44 +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 09, 2018 at 11:42:16AM -0800, Joe Perches wrote:
> > > if (a == b && c == d)
> > > is pretty trivial.
> >
> > But again, don't do that.
> 
> <shrug> We disagree. Life goes on.
> 
> cheers, Joe
>
>

For me the line above isn't obvious and easy to read. If I would be in doubt, whether it really performs correctly, I would have to ask the c-guide, to be absolutely shure.
But to be honest: If I need to find a bug arround taht lines, I wouldn't ask the c-guide, but simply add some (). Then it would be 100% clear and no one would be in doubt any more.

What's the disadvantage of () to emphasise waht is going on. An other Option for me would be, to spend a command line and write that info in form of a comment.


Just my opinion and the way, I would go on if I am in doubt and need to find a bug.

Cheers,

Marcus