Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755250AbeAJKWC (ORCPT + 1 other); Wed, 10 Jan 2018 05:22:02 -0500 Received: from mx2.suse.de ([195.135.220.15]:51770 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755107AbeAJKV6 (ORCPT ); Wed, 10 Jan 2018 05:21:58 -0500 Date: Wed, 10 Jan 2018 11:21:56 +0100 Message-ID: From: Takashi Iwai To: "Mark Brown" Cc: "Ryan Lee" , , , , , Subject: Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ comments style In-Reply-To: <20180110101506.GC9003@sirena.org.uk> References: <1515560521-10850-1-git-send-email-ryans.lee@maximintegrated.com> <20180110101506.GC9003@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, 10 Jan 2018 11:15:06 +0100, Mark Brown wrote: > > On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote: > > > @@ -1,4 +1,4 @@ > > -/* SPDX-License-Identifier: GPL-2.0 */ > > +// SPDX-License-Identifier: GPL-2.0 > > /* Copyright (c) 2017, Maxim Integrated */ > > Please change the entire header to C++, mixing C and C++ on adjacent > lines looks ugly. I'm not sure whether it's a good direction to go, either. I rather wonder why SPDX line *must* be in C++ comment style... thanks, Takashi