Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753277AbeAJKfn (ORCPT + 1 other); Wed, 10 Jan 2018 05:35:43 -0500 Received: from mail-he1eur01on0089.outbound.protection.outlook.com ([104.47.0.89]:44430 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751409AbeAJKfk (ORCPT ); Wed, 10 Jan 2018 05:35:40 -0500 From: Yossef Efraim To: Steffen Klassert CC: "David S. Miller" , Herbert Xu , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Boris Pismenny , "Yevgeny Kliteynik" , Yossi Kuperman Subject: RE: [PATCH net-next 3/3] xfrm: Add ESN support for IPSec HW offload Thread-Topic: [PATCH net-next 3/3] xfrm: Add ESN support for IPSec HW offload Thread-Index: AQHTaC49YNlGHAWMkU6aq8Ji5FPjlaMuCWiAgD8jc3A= Date: Wed, 10 Jan 2018 10:35:37 +0000 Message-ID: References: <1511862571-3494-1-git-send-email-yossefe@mellanox.com> <1511862571-3494-3-git-send-email-yossefe@mellanox.com> <20171201062321.dt3jbrfs4svwpgqx@gauss3.secunet.de> In-Reply-To: <20171201062321.dt3jbrfs4svwpgqx@gauss3.secunet.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yossefe@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0501MB2239;7:FIwMuhHno+nQdCTXdHmFNpkHt25erRrEC74qvU+bg/iKata5DwK3Ah6RRIjK4lDl6kOIqRKWjID2iLBi08zduNhqdYMCZ1kRCqYarn5cKDpk5NYThIfiF/F4wf8Al670DjcRVmQwZdEW6wjw6NiyLphZ0Z88OopENvIpj/Bnu8ymf24dKx4jo1A72n0htbbwJiwZrqbuQmRNVH2c/mbxPfTgyfsSAkmnZGc5jJw1GKUVOPdTwGgQXyYmsNm0kJGg x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e2a6344d-bb75-43e6-49ec-08d55815e351 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:VI1PR0501MB2239; x-ms-traffictypediagnostic: VI1PR0501MB2239: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231023)(944501119)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(6072148)(201708071742011);SRVR:VI1PR0501MB2239;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR0501MB2239; x-forefront-prvs: 0548586081 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39380400002)(366004)(396003)(39860400002)(346002)(376002)(24454002)(13464003)(199004)(189003)(25786009)(6436002)(81156014)(316002)(3846002)(81166006)(14454004)(8676002)(106356001)(54906003)(107886003)(6116002)(229853002)(8936002)(4326008)(6246003)(105586002)(5660300001)(76176011)(3280700002)(5250100002)(7696005)(55016002)(53936002)(99286004)(9686003)(33656002)(53546011)(3660700001)(7736002)(305945005)(74316002)(2900100001)(6506007)(66066001)(478600001)(6916009)(2906002)(2950100002)(102836004)(86362001)(97736004)(68736007);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0501MB2239;H:VI1PR0502MB3758.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: 15ylJijuf1I6G7T5mNDh7pcsAF5BDgK8ouAtJUd1htzzKVytR/oCSH4+5Nr1bkNVi13EvnAnYzr8DD+02ASEPg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2a6344d-bb75-43e6-49ec-08d55815e351 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2018 10:35:37.3012 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2239 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Ok Doc updated. Sending this patch again with all the fixes. Thanks! > -----Original Message----- > From: Steffen Klassert [mailto:steffen.klassert@secunet.com] > Sent: Friday, December 01, 2017 8:23 AM > To: Yossef Efraim > Cc: David S. Miller ; Herbert Xu > ; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Boris Pismenny ; Yevgeny > Kliteynik ; Yossi Kuperman > Subject: Re: [PATCH net-next 3/3] xfrm: Add ESN support for IPSec HW offload > > On Tue, Nov 28, 2017 at 11:49:30AM +0200, yossefe@mellanox.com wrote: > > From: Yossef Efraim > > > > This patch adds ESN support to IPsec device offload. > > Adding new xfrm device operation to synchronize device ESN. > > > > Signed-off-by: Yossef Efraim > > --- > > include/linux/netdevice.h | 1 + > > include/net/xfrm.h | 12 ++++++++++++ > > net/xfrm/xfrm_device.c | 4 ++-- > > net/xfrm/xfrm_replay.c | 2 ++ > > 4 files changed, 17 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index 7de7656..d4e9198 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netdevice.h > > @@ -825,6 +825,7 @@ struct xfrmdev_ops { > > void (*xdo_dev_state_free) (struct xfrm_state *x); > > bool (*xdo_dev_offload_ok) (struct sk_buff *skb, > > struct xfrm_state *x); > > + void (*xdo_dev_state_advance_esn) (struct xfrm_state *x); > > We now have a documentation for the xfrm offloadin API in the ipsec-next tree. > Please document the new device operation there and resubmit. > > Thanks!