Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965020AbeAJLT6 (ORCPT + 1 other); Wed, 10 Jan 2018 06:19:58 -0500 Received: from mail-oi0-f48.google.com ([209.85.218.48]:46861 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752093AbeAJLTz (ORCPT ); Wed, 10 Jan 2018 06:19:55 -0500 X-Google-Smtp-Source: ACJfBosmjITnsHb4j8HRkL9EflWbdrxTZTNh8Ke3WRGYMKm3A66OOpwItKqiWcQoDJMqREBXUvChPhWajMfkZca9uT4= MIME-Version: 1.0 In-Reply-To: <20180110130230-mutt-send-email-mst@kernel.org> References: <20180109190414.4017-1-suzuki.poulose@arm.com> <20180109190414.4017-2-suzuki.poulose@arm.com> <20180110012429-mutt-send-email-mst@kernel.org> <20180110130230-mutt-send-email-mst@kernel.org> From: Peter Maydell Date: Wed, 10 Jan 2018 11:19:34 +0000 Message-ID: Subject: Re: [PATCH v1 01/16] virtio: Validate queue pfn for 32bit transports To: "Michael S. Tsirkin" Cc: Suzuki K Poulose , arm-mail-list , kvm-devel , kvmarm@lists.cs.columbia.edu, Christoffer Dall , Marc Zyngier , lkml - Kernel Mailing List , kristina.martsenko@arm.com, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Will Deacon , Ard Biesheuvel , Mark Rutland , Catalin Marinas , Jason Wang , Christoffer Dall Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 10 January 2018 at 11:06, Michael S. Tsirkin wrote: > For virtio-mmio? I don't seem to see that code in > hw/virtio/virtio-mmio.c > For example I still see handling for VIRTIO_MMIO_QUEUE_PFN > there, and no handling for VIRTIO_MMIO_QUEUE_DESC_LOW > and such. Are there uses that make it worthwhile to get virtio-1 support added to virtio-mmio, rather than just getting people to move over to virtio-pci instead ? thanks -- PMM