Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933156AbeAJLa7 (ORCPT + 1 other); Wed, 10 Jan 2018 06:30:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46922 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932459AbeAJLaz (ORCPT ); Wed, 10 Jan 2018 06:30:55 -0500 Date: Wed, 10 Jan 2018 13:30:52 +0200 From: "Michael S. Tsirkin" To: Peter Maydell Cc: Suzuki K Poulose , arm-mail-list , kvm-devel , kvmarm@lists.cs.columbia.edu, Christoffer Dall , Marc Zyngier , lkml - Kernel Mailing List , kristina.martsenko@arm.com, Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Will Deacon , Ard Biesheuvel , Mark Rutland , Catalin Marinas , Jason Wang , Christoffer Dall Subject: Re: [PATCH v1 01/16] virtio: Validate queue pfn for 32bit transports Message-ID: <20180110132930-mutt-send-email-mst@kernel.org> References: <20180109190414.4017-1-suzuki.poulose@arm.com> <20180109190414.4017-2-suzuki.poulose@arm.com> <20180110012429-mutt-send-email-mst@kernel.org> <20180110130230-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 10 Jan 2018 11:30:55 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 10, 2018 at 11:19:34AM +0000, Peter Maydell wrote: > On 10 January 2018 at 11:06, Michael S. Tsirkin wrote: > > For virtio-mmio? I don't seem to see that code in > > hw/virtio/virtio-mmio.c > > For example I still see handling for VIRTIO_MMIO_QUEUE_PFN > > there, and no handling for VIRTIO_MMIO_QUEUE_DESC_LOW > > and such. > > Are there uses that make it worthwhile to get virtio-1 > support added to virtio-mmio, rather than just getting > people to move over to virtio-pci instead ? > > thanks > -- PMM I keep getting these patches (like the one that started this thread) so I think yes. If nothing else the guest support will bit-rot without an open-source implementation. -- MST