Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754845AbeAJMUT (ORCPT + 1 other); Wed, 10 Jan 2018 07:20:19 -0500 Received: from mail-ot0-f196.google.com ([74.125.82.196]:34988 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751407AbeAJMUQ (ORCPT ); Wed, 10 Jan 2018 07:20:16 -0500 X-Google-Smtp-Source: ACJfBouHlOwmj29DFkFf5GqCFKN4ggOWHgl3PpxYjwItSDFFIPHrMIl0qz4HjIWWQ4ep2u/3aZeBROgIfqXbYoFJS5o= MIME-Version: 1.0 In-Reply-To: <20180109223126.13093-5-jae.hyun.yoo@linux.intel.com> References: <20180109223126.13093-1-jae.hyun.yoo@linux.intel.com> <20180109223126.13093-5-jae.hyun.yoo@linux.intel.com> From: Arnd Bergmann Date: Wed, 10 Jan 2018 13:20:15 +0100 X-Google-Sender-Auth: iQxMNcoBbZ6TPA2AyhlCTL-3wfA Message-ID: Subject: Re: [PATCH linux dev-4.10 4/6] Documentation: dt-bindings: Add a generic PECI hwmon To: Jae Hyun Yoo Cc: Joel Stanley , Andrew Jeffery , gregkh , Jean Delvare , Guenter Roeck , Linux Kernel Mailing List , linux-doc@vger.kernel.org, DTML , linux-hwmon@vger.kernel.org, Linux ARM , OpenBMC Maillist Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 9, 2018 at 11:31 PM, Jae Hyun Yoo wrote: > This commit add a dt-bindings document for a generic PECI hwmon > driver. > > Signed-off-by: Jae Hyun Yoo > --- > .../devicetree/bindings/hwmon/peci-hwmon.txt | 33 ++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/peci-hwmon.txt > > diff --git a/Documentation/devicetree/bindings/hwmon/peci-hwmon.txt b/Documentation/devicetree/bindings/hwmon/peci-hwmon.txt > new file mode 100644 > index 0000000..20b86f5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/peci-hwmon.txt > @@ -0,0 +1,33 @@ > +* Generic PECI (Platform Environment Control Interface) hwmon driver. > + > +Dependency: > +- This driver uses a PECI misc driver as a controller interface so one of PECI > + misc drivers which provides compatible ioctls has to be enabled. The binding should only explain how we describe the hardware in an operating-system independent way, but not talk about how an OS is supposed to implement those drivers. Having multiple drivers each provide an exported function is not possible in Linux: it immediately breaks building an 'allyesconfig' kernel, and prevents you from running the same kernel across multiple implementations, so that has to be redesigned anyway. > +Required properties: > +- compatible: "peci-hwmon" > +- cpu-id: Should contain CPU socket ID > + - 0 ~ 7 > + > +Optional properties: > +- show-core: If this protperty is defined, core tmeperature attrubites will be s/protperty/property/ s/tmeperature/temperature/ s/attrubites/attributes/ > + enumerated. > +- dimm-nums: Should contain the number of DIMM slots that attached to each CPU > + which is indicated by cpu-id. > + 0 ~ 16 (default: 16) > + In case of 0, DIMM temperature attrubites will not be enumerated. Is this only an initial list that you expect to be extended in the future, or is this a complete list of sensors that can ever be connected to PECI? Should this be PECI version specific? Arnd