Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965549AbeAJM2C (ORCPT + 1 other); Wed, 10 Jan 2018 07:28:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55394 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965529AbeAJM17 (ORCPT ); Wed, 10 Jan 2018 07:27:59 -0500 Date: Wed, 10 Jan 2018 13:27:55 +0100 From: Andrea Arcangeli To: David Woodhouse Cc: Peter Zijlstra , Dave Hansen , Thomas Gleixner , LKML , Linus Torvalds , x86@kernel.org, Borislav Petkov , Tim Chen , Andi Kleen , Greg KH , Andy Lutomirski , Arjan Van De Ven Subject: Re: [patch RFC 5/5] x86/speculation: Add basic speculation control code Message-ID: <20180110122755.GF9706@redhat.com> References: <20180110011350.855878109@linutronix.de> <20180110092234.GY29822@worktop.programming.kicks-ass.net> <1515576479.22302.81.camel@infradead.org> <20180110115419.GA9706@redhat.com> <1515585534.22302.122.camel@infradead.org> <20180110120158.GB9706@redhat.com> <20180110120721.GC9706@redhat.com> <1515586373.22302.129.camel@infradead.org> <20180110122045.GE9706@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180110122045.GE9706@redhat.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 10 Jan 2018 12:27:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 10, 2018 at 01:20:45PM +0100, Andrea Arcangeli wrote: > On Wed, Jan 10, 2018 at 12:12:53PM +0000, David Woodhouse wrote: > > IBRS is like a barrier. You must write it between the 'problematic' > > loading of the branch targets, and the kernel code which might be > > affected. > > > > You cannot, on current hardware, merely set it once and forget about > > it. That is not sufficient. > > I think you've got it all wrong... On a side note, I hope once you get it right, the debugfs tunable will suddenly look less horrid.