Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934640AbeAJM7o (ORCPT + 1 other); Wed, 10 Jan 2018 07:59:44 -0500 Received: from lelnx193.ext.ti.com ([198.47.27.77]:62488 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbeAJM7l (ORCPT ); Wed, 10 Jan 2018 07:59:41 -0500 Subject: Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume To: Felipe Balbi , Manu Gautam CC: , , Greg Kroah-Hartman , open list , linux-omap References: <1506511163-26026-1-git-send-email-mgautam@codeaurora.org> <6b0ceec7-7620-3d03-ad43-6dca7cbca3e8@ti.com> <876089zxau.fsf@linux.intel.com> From: Roger Quadros Message-ID: Date: Wed, 10 Jan 2018 14:59:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <876089zxau.fsf@linux.intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-GB Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 10/01/18 14:57, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> Hi Manu, >> >> On 27/09/17 14:19, Manu Gautam wrote: >>> Driver powers-off PHYs and reinitializes DWC3 core and gadget on >>> resume. While this works fine for gadget mode but in host >>> mode there is not re-initialization of host stack. Also, resetting >>> bus as part of bus_suspend/resume is not correct which could affect >>> (or disconnect) connected devices. >>> Fix this by not reinitializing core on suspend/resume in host mode >>> for HOST only and OTG/drd configurations. >>> >> >> All this seems correct but we (TI) were relying on dwc3_core_exit() to be called >> during dwc3_suspend() to have the lowest power state for our platforms. >> >> After this patch, DWC3 controller and PHYs won't be turned off thus >> preventing our platform from reaching low power levels. >> >> So this is a regression for us (TI) in v4.15-rc. >> >> Felipe, do you agree? >> >> If yes I can send a patch which fixes the regression >> and also makes USB host work after suspend/resume. > > A power consumption regression is still a regression. But it's super > late in the -rc cycle, I think we need to get this merged after 4.16-rc1 > and make sure to Cc stable. > > Should be more than enough time to review and test patches. > Fine with me. -- cheers, -roger Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki