Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753368AbeAJNLv (ORCPT + 1 other); Wed, 10 Jan 2018 08:11:51 -0500 Received: from mga07.intel.com ([134.134.136.100]:16637 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284AbeAJNLu (ORCPT ); Wed, 10 Jan 2018 08:11:50 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,340,1511856000"; d="scan'208";a="9000560" Message-ID: <1515589905.7000.847.camel@linux.intel.com> Subject: Re: [PATCH v1 1/4] bitmap: Add bitmap_zero()/bitmap_clear() test cases From: Andy Shevchenko To: Yury Norov Cc: Andrew Morton , linux-kernel@vger.kernel.org, Rasmus Villemoes , Randy Dunlap Date: Wed, 10 Jan 2018 15:11:45 +0200 In-Reply-To: <20180110093405.zhz3smxy264kmghv@yury-thinkpad> References: <20180109172430.87452-1-andriy.shevchenko@linux.intel.com> <20180110093405.zhz3smxy264kmghv@yury-thinkpad> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, 2018-01-10 at 12:34 +0300, Yury Norov wrote: > Hi Andy, > > On Tue, Jan 09, 2018 at 07:24:27PM +0200, Andy Shevchenko wrote: > > Explicitly test bitmap_zero() and bitmap_clear() functions. > > + /* Known way to set all bits */ > > Nit: if you start your comments with capital, proceed that way till > the end. Right, I have to keep the original style. I'll check this. > I don't understand what patch #4 is doing in this series. At the first > glance, it may be applied separately. It fixes test failures found by patch 2 in the series. The idea is similar to TDD. > The rest is looking fine. For 1-3, > Reviewed-by: Yury Norov Thanks. -- Andy Shevchenko Intel Finland Oy