Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965025AbeAJNsT (ORCPT + 1 other); Wed, 10 Jan 2018 08:48:19 -0500 Received: from mga05.intel.com ([192.55.52.43]:11442 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031AbeAJNsS (ORCPT ); Wed, 10 Jan 2018 08:48:18 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,340,1511856000"; d="scan'208";a="18980808" Message-ID: <1515591811.7000.870.camel@linux.intel.com> Subject: Re: [PATCH v6 5/5] iommu/vt-d: Add debugfs support for Interrupt remapping From: Andy Shevchenko To: Sohil Mehta , Joerg Roedel , Alex Williamson Cc: Ashok Raj , David Woodhouse , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Jacob Pan , Gayatri Kammela , Ravi V Shankar , Lu Baolu , Fenghua Yu Date: Wed, 10 Jan 2018 15:43:31 +0200 In-Reply-To: <1515556102-34150-6-git-send-email-sohil.mehta@intel.com> References: <1515556102-34150-1-git-send-email-sohil.mehta@intel.com> <1515556102-34150-6-git-send-email-sohil.mehta@intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, 2018-01-09 at 19:48 -0800, Sohil Mehta wrote: > Debugfs extension for Intel IOMMU to dump Interrupt remapping table > entries for Interrupt remapping and Interrupt posting. > > The file /sys/kernel/debug/intel_iommu/ir_translation_struct provides > detailed information, such as Index, Source Id, Destination Id, Vector > and the raw values for entries with the present bit set, in the format > shown. > > Remapped Interrupt supported on IOMMU: dmar5 > IR table address:ffff93e09d54c310 > ----------------------------------------------------------- > Index SID Dest_ID Vct Raw_value_high Raw_value_low > 1 3a00 00000600 2c 0000000000043a00 00000600002c0009 > 111 4301 00000900 a2 0000000000044301 0000090000a20009 > > Posted Interrupt supported on IOMMU: dmar5 > IR table address:ffff93e09d54c310 > -------------------------------------------------------------------- > Index SID PDA_high PDA_low Vct Raw_value_high Raw_value_low > 4 4300 00000010 40c7c880 41 0000001000044300 40c7c88000418001 > 5 4300 00000010 40c7c880 51 0000001000044300 40c7c88000518001 > > > + seq_printf(m, "Remapped Interrupt supported on IOMMU: > %s\n" > + " IR table address:%p\n", iommu->name, > + iommu->ir_table); A nit: If you indent second part of string literal to follow the indentation of first one, it would be slightly better for my opinion. > + seq_printf(m, "Posted Interrupt supported on IOMMU: > %s\n" > + " IR table address:%p\n", iommu->name, > + iommu->ir_table); Ditto. -- Andy Shevchenko Intel Finland Oy