Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755377AbeAJOPs (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Wed, 10 Jan 2018 09:15:48 -0500
Received: from userp2130.oracle.com ([156.151.31.86]:45364 "EHLO
        userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753867AbeAJOPq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 Jan 2018 09:15:46 -0500
Date: Wed, 10 Jan 2018 17:15:00 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Luis de Bethencourt <luisbg@kernel.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Bastien Nocera <hadess@hadess.net>,
        Joe Perches <joe@perches.com>,
        Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 3/3] staging: rtl8723bs: Fix trailing semicolon in comment
Message-ID: <20180110141500.oxp2bblistv5cklv@mwanda>
References: <20180110135038.32293-1-luisbg@kernel.org>
 <20180110135038.32293-4-luisbg@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180110135038.32293-4-luisbg@kernel.org>
User-Agent: NeoMutt/20170609 (1.8.3)
X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8769 signatures=668652
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=668
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.0.1-1711220000 definitions=main-1801100200
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Wed, Jan 10, 2018 at 01:50:38PM +0000, Luis de Bethencourt wrote:
> Even though the code is commented out, it has a small bug. The trailing
> semicolon is an empty statement that does no operation. Removing it since
> it doesn't do anything.

It's not a bug because it's totally harmless to add extra semicolons.

But it's better to just delete all the commented out lines.  I don't
really want to see a bunch of patches to code which should just be
deleted.

regards,
dan carpenter