Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755597AbeAJOQq (ORCPT + 1 other); Wed, 10 Jan 2018 09:16:46 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:60156 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752108AbeAJOQo (ORCPT ); Wed, 10 Jan 2018 09:16:44 -0500 From: Wei Yongjun To: Daniel Lezcano , Thomas Gleixner , Maxime Coquelin , "Alexandre Torgue" CC: Wei Yongjun , , , Subject: [PATCH -next] clocksource/drivers/stm32: fix error return code in stm32_timer_init() Date: Wed, 10 Jan 2018 14:23:00 +0000 Message-ID: <1515594180-80214-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Fix to return error code -ENOMEM from the kzalloc error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/clocksource/timer-stm32.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c index e5cdc3a..2717f88 100644 --- a/drivers/clocksource/timer-stm32.c +++ b/drivers/clocksource/timer-stm32.c @@ -304,8 +304,10 @@ static int __init stm32_timer_init(struct device_node *node) to->private_data = kzalloc(sizeof(struct stm32_timer_private), GFP_KERNEL); - if (!to->private_data) + if (!to->private_data) { + ret = -ENOMEM; goto deinit; + } rstc = of_reset_control_get(node, NULL); if (!IS_ERR(rstc)) {